-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specifying path to source files #74
Comments
Hi Rob, two answers :
Eg, if you built with sources in /rpm/.... and run on another machine where you copied the sources in /home/me/ malt-webview --override /rpm/my-project:/home/me/my-project -i malt-123456-my-program.json Fill free to precise if it is not working for you. |
I tried the -o option, but isn't working. Is there a way to display the original source path that web view is expecting? |
…' disapear from the requset (issue #74).
Ohhhh, thanks for the report, there is effectively a real bug. You can see the path of the file in the webview source browser when it failed to fetch the file. You are most probably in the case where your sources are pointed via a relative paths which trigger a bug in the webview making the './' disappearing while arriving on the mini-server. I fixed it in master branch. If you are in this case it might be fixed. For relative path replacement you might use, or it might work automatically if you are located in the source directory. malt-webview --override ./:/home/me/my-project -i malt-123456-my-program.json If you can confirm it is your issue. |
I'm still unable to get it to work, even after pulling your fix. Let's say my source code is located on the remote machine at
/usr/workspace/myproject/src
I copied the json output malt file to my local machine and cloned 'myproject' in the same directory. I then tried
malt-webview --no-auth -p 9090 -i output.json -o /usr/workspace/myproject/src:./myproject/src
I still don't see the source code. I did make sure to build my executable with '-g'.
…________________________________
From: Sébastien Valat ***@***.***>
Sent: Wednesday, May 17, 2023 4:21 PM
To: memtt/malt
Cc: Aulwes, Rob Tuan; Author
Subject: [EXTERNAL] Re: [memtt/malt] Specifying path to source files (Issue #74)
Ohhhh, thanks for the report, there is effectively a real bug.
You can see the path of the file in the webview source browser when it failed to fetch the file.
You are most probably in the case where your sources are pointed via a relative paths which trigger a bug in the webview making the './' disappearing while arriving on the mini-server.
I fixed it in master branch.
If you are in this case it might be fixed.
For relative path replacement you might use, or it might work automatically if you are located in the source directory.
malt-webview --override ./:/home/me/my-project -i malt-123456-my-program.json
If you can confirm it is your issue.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/memtt/malt/issues/74*issuecomment-1552162092__;Iw!!Bt8fGhp8LhKGRg!Hos-NEqjp0Qk-hl7JjwABJdUiq8V8D_ZkDf9f781YMNPBTJMnYVgJ8YWHzOO-en-wSxDs7RS7ysnVB6ieMvxeA$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB46TOTVEELQCALVM3YRXZDXGVFPLANCNFSM6AAAAAAYEDRMDA__;!!Bt8fGhp8LhKGRg!Hos-NEqjp0Qk-hl7JjwABJdUiq8V8D_ZkDf9f781YMNPBTJMnYVgJ8YWHzOO-en-wSxDs7RS7ysnVB6R7exp5g$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Pretty sur I still have an issue on the ./ in the target part of the redirection, I will give a look. Waiting the patch, can you try to put a full path instead of ./ ? |
In principle I made the fix on master branch. |
I rebuilt, but now I'm getting this error when I attempt to run:
srun -n 4 --ntasks-per-socket=2 --cpus-per-task=2 $MALT_ROOT/bin/malt -s libunwind --mpi -- myapp.x
/g/g15/aulwes1/workspace/malt/src/lib/stacks/Stack.cpp:497: void MALT::Stack::fastSkip(int): Assertion `depth >= 0 && depth < size' failed.
/usr/workspace/perfeng/utils/malt/bin/malt: line 448: 524516 Aborted (core dumped) LD_PRELOAD="${MPI_WRAPPER_DIR}/libmaltmpi.so:${MALT_LIB}:${LD_PRELOAD}" "$@"
/g/g15/aulwes1/workspace/malt/src/lib/stacks/Stack.cpp:497: void MALT::Stack::fastSkip(int): Assertion `depth >= 0 && depth < size' failed.
/g/g15/aulwes1/workspace/malt/src/lib/stacks/Stack.cpp:497: void MALT::Stack::fastSkip(int): Assertion `depth >= 0 && depth < size' failed.
/usr/workspace/perfeng/utils/malt/bin/malt: line 448: 524512 Aborted (core dumped) LD_PRELOAD="${MPI_WRAPPER_DIR}/libmaltmpi.so:${MALT_LIB}:${LD_PRELOAD}" "$@"
/g/g15/aulwes1/workspace/malt/src/lib/stacks/Stack.cpp:497: void MALT::Stack::fastSkip(int): Assertion `depth >= 0 && depth < size' failed.
/usr/workspace/perfeng/utils/malt/bin/malt: line 448: 524511 Aborted (core dumped) LD_PRELOAD="${MPI_WRAPPER_DIR}/libmaltmpi.so:${MALT_LIB}:${LD_PRELOAD}" "$@"
/usr/workspace/perfeng/utils/malt/bin/malt: line 448: 524514 Aborted (core dumped) LD_PRELOAD="${MPI_WRAPPER_DIR}/libmaltmpi.so:${MALT_LIB}:${LD_PRELOAD}" "$@"
flux-job: task(s) exited with exit code 134
I built using:
cmake .. -DLIBUNWIND_PREFIX=/usr/lib64/libunwind-x86_64.so -DCMAKE_INSTALL_PREFIX=/usr/workspace/perfeng/utils/malt
The compilers I'm using are Clang 14.0.6. Should I be using a different compiler?
…________________________________
From: Sébastien Valat ***@***.***>
Sent: Wednesday, May 31, 2023 6:29:21 PM
To: memtt/malt
Cc: Aulwes, Rob Tuan; Author
Subject: [EXTERNAL] Re: [memtt/malt] Specifying path to source files (Issue #74)
In principle I made the fix on master branch.
If you can check and confirm or infirm.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/memtt/malt/issues/74*issuecomment-1571139169__;Iw!!Bt8fGhp8LhKGRg!DZg8Xm3284V7SFDlvbVQwjoGKrRwvefdhQqqKqB7gaK9iWFIG0zOABYiPJ11Bfkbs3qTgGHcdfyqCgb0cIKpQg$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB46TOQP6YMZK4US6HVZCELXI7O6DANCNFSM6AAAAAAYEDRMDA__;!!Bt8fGhp8LhKGRg!DZg8Xm3284V7SFDlvbVQwjoGKrRwvefdhQqqKqB7gaK9iWFIG0zOABYiPJ11Bfkbs3qTgGHcdfyqCgbx6w03UQ$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
So if I well understand you get the issue since you moved to master branch and before you got success with probably the released version 1.2.1 ? Or am I wrong ? |
I'm sure I've made a mistake somewhere. I was getting this same error before as well, but at that time, the fix was to use GCC 9.3.0 and also to specify '-s libunwind'. However, this time, I tried the same thing, to use GCC 10.3.0 and libunwind, but getting this error again. I then tried '-s enter-exit' and this option worked. But does this mean I won't get a stack trace?
…________________________________
From: Sébastien Valat ***@***.***>
Sent: Thursday, June 1, 2023 9:45:40 AM
To: memtt/malt
Cc: Aulwes, Rob Tuan; Author
Subject: [EXTERNAL] Re: [memtt/malt] Specifying path to source files (Issue #74)
So if I well understand you get the issue since you moved to master branch and before you got success with probably the released version 1.2.1 ?
Or am I wrong ?
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/memtt/malt/issues/74*issuecomment-1572300195__;Iw!!Bt8fGhp8LhKGRg!AYLZzGBsuFHFTfataTfzuIiHIGnbz7POwAnZEvJ5abwU68nndgQlJtFuu24FhGaf250JLgV0AGlvvj_t6bvAYA$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB46TOX4LHNT4ZVHCKPHXUDXJC2KJANCNFSM6AAAAAAYEDRMDA__;!!Bt8fGhp8LhKGRg!AYLZzGBsuFHFTfataTfzuIiHIGnbz7POwAnZEvJ5abwU68nndgQlJtFuu24FhGaf250JLgV0AGlvvj9PHv6gXA$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
The issue related to You can try to see if another value of the skip parameter might fix your issue manually via the options : malt -o stack:skip=3 ......
malt -o stack:skip=4 ......
malt -o stack:skip=5 ...... |
Yup, stack:skip=3, worked!! Thanks!!
…________________________________
From: Sébastien Valat ***@***.***>
Sent: Thursday, June 1, 2023 9:53:20 AM
To: memtt/malt
Cc: Aulwes, Rob Tuan; Author
Subject: [EXTERNAL] Re: [memtt/malt] Specifying path to source files (Issue #74)
The issue related to fastSkip is related the the backtrace on which I skip the first entries not to look on my own internal functions. But the exact value to use might depend on the way your compiler as inlined some functions. In principle this is detected but I probably have an issue if you get the error.
You can try to see if another value of the skip parameter might fix your issue manually via the options :
malt -o stack:skip=3 ......
malt -o stack:skip=4 ......
malt -o stack:skip=5 ......
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/memtt/malt/issues/74*issuecomment-1572312289__;Iw!!Bt8fGhp8LhKGRg!FXmZjTRcZKxIb2rwN9h9G_66LCbVQHUoxE7rSeU-ETvgj79fkRh_gUEAnGIHjdKmpvllavX8MTA5s3DPMYXG8A$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB46TOVAT3I7OQ5X5RWDOBLXJC3HBANCNFSM6AAAAAAYEDRMDA__;!!Bt8fGhp8LhKGRg!FXmZjTRcZKxIb2rwN9h9G_66LCbVQHUoxE7rSeU-ETvgj79fkRh_gUEAnGIHjdKmpvllavX8MTA5s3CnPUImpw$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
As you directly call Probably i need to fix something in debug mode. cmake .. -DCMAKE_BUILD_TYPE=Release ....... |
Ok, I'll try that, thank you!
…________________________________
From: Sébastien Valat ***@***.***>
Sent: Thursday, June 1, 2023 9:55:46 AM
To: memtt/malt
Cc: Aulwes, Rob Tuan; Author
Subject: [EXTERNAL] Re: [memtt/malt] Specifying path to source files (Issue #74)
As you directly call cmakeyou can also try to build in release mode which enable all the optimizations which impact this. I apply it automatically if you use the ./configure script.
Probably i need to fix something in debug mode.
cmake .. -DCMAKE_BUILD_TYPE=Release .......
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/memtt/malt/issues/74*issuecomment-1572315604__;Iw!!Bt8fGhp8LhKGRg!FuNSPCdPqeoUnShJpVeKeKx-QUUpOFGdkKK3eymGyDjyXAytp7Qd3efv8DM0aRVooipZ8uT6abSkKJmLNV4sgQ$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB46TOTWBULLXUEZQLYNX4DXJC3QFANCNFSM6AAAAAAYEDRMDA__;!!Bt8fGhp8LhKGRg!FuNSPCdPqeoUnShJpVeKeKx-QUUpOFGdkKK3eymGyDjyXAytp7Qd3efv8DM0aRVooipZ8uT6abSkKJn89yiuGQ$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I moved the second issue your reported in #76 so I can close this one. |
Ok, thanks, I’m still having trouble getting the source code to appear. I’m trying to add log outputs in the webview source to show where it thinks the source codes are located.
From: Sébastien Valat ***@***.***>
Reply-To: memtt/malt ***@***.***>
Date: Saturday, June 17, 2023 at 1:32 PM
To: memtt/malt ***@***.***>
Cc: "Aulwes, Rob Tuan" ***@***.***>, Author ***@***.***>
Subject: [EXTERNAL] Re: [memtt/malt] Specifying path to source files (Issue #74)
I moved the second issue your reported in #76<https://urldefense.com/v3/__https:/github.com/memtt/malt/issues/76__;!!Bt8fGhp8LhKGRg!AH5R5Ivw8U5L7MGaj_K5HGYQtVhosJNB4jCmIW27KU-4dCC2BERfCv_e55PbY6QXHXaS4eavJ9JGO1X435XnSg$> so I can close this one.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/memtt/malt/issues/74*issuecomment-1595842458__;Iw!!Bt8fGhp8LhKGRg!AH5R5Ivw8U5L7MGaj_K5HGYQtVhosJNB4jCmIW27KU-4dCC2BERfCv_e55PbY6QXHXaS4eavJ9JGO1Xk9uYV2g$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AB46TOVWXOGFAFE3ZJA4FTLXLYA5BANCNFSM6AAAAAAYEDRMDA__;!!Bt8fGhp8LhKGRg!AH5R5Ivw8U5L7MGaj_K5HGYQtVhosJNB4jCmIW27KU-4dCC2BERfCv_e55PbY6QXHXaS4eavJ9JGO1VWZpXthA$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hi,
How do I specify the path(s) to the source files so that they are displayed in malt-webview?
Thanks,Rob
The text was updated successfully, but these errors were encountered: