Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEN-7288 - feat/threshold migration #4443

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

mzedel
Copy link
Contributor

@mzedel mzedel commented Jun 5, 2024

Screenshot 2024-06-18 at 12 15 52

@mender-test-bot
Copy link
Contributor

@mzedel, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline".


my commands and options

You can trigger a pipeline on multiple prs with:

  • mentioning me and start pipeline --pr mender/127 --pr mender-connect/255

You can start a fast pipeline, disabling full integration tests with:

  • mentioning me and start pipeline --fast

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@mzedel mzedel force-pushed the feat/threshold-migration branch 3 times, most recently from 2146d91 to 955e86f Compare June 6, 2024 09:33
@estenberg
Copy link
Contributor

Looks good, just would clarify the "What's changing" part. In particular what does "detected" and "any contact with Mender" mean? I would perhaps make it a bit more technical so that it's more clear. Those people reading are pretty technical anyway. :)

@mzedel
Copy link
Contributor Author

mzedel commented Jun 11, 2024

@estenberg thank you for looking into this! Would the following be enough?:

offline devices can only be filtered for after at least one full day without any API request to the Mender backend

@estenberg
Copy link
Contributor

Better, but API request can mean many things, such as the user or UI making an API request..

Perhaps "For filtering / listing which devices are offline, the data filtered on may be up to one day old. In other words, if the device has been offline for a while and only recently contacted the Mender server, it may still be listed as offline until the data filtered on is updated (within 1 day)."

@estenberg
Copy link
Contributor

Overall I feel this was a convoluted change (long time ago), that focused more on our infra performance than how it affected the user. It is what it is now, but we need to do better next time.

@mzedel
Copy link
Contributor Author

mzedel commented Jun 14, 2024

Better, but API request can mean many things, such as the user or UI making an API request..

then maybe: offline devices can only be filtered for after at least one full day without any API request by a device to the Mender backend 🙃

Perhaps "For filtering / listing which devices are offline, the data filtered on may be up to one day old. In other words, if the device has been offline for a while and only recently contacted the Mender server, it may still be listed as offline until the data filtered on is updated (within 1 day)."

Afaik it is a bit the other way around: if the device has been offline for a few hours it won't be listed as offline before 1 day has passed, whereas if it was offline for a while, the device coming back online will be visible right away. Here a device coming back online means: any request to the API by a device.

@estenberg
Copy link
Contributor

I am so confused by this. :-/

@estenberg
Copy link
Contributor

estenberg commented Jun 14, 2024

Okey, let me try again:

"If a device no longer connects with the server, it may take up to 1 day until it is shown as an offline device in the UI."

<>
In our continuous efforts to enhance performance and to ensure the stability of our service, we have made adjustments to how granular device connectivity
can be checked.
<h4>What&apos;s Changing:</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to lowercase "c"

…ing days

Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
can be checked.
<h4>What&apos;s Changing:</h4>
<ul>
<li>If a device no longer connects with the server, it may take up to 1 day until it is shown as an offline device in the UI.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add to the start of this line:
"Offline threshold: if a device..."

Using the same name it has in the settings, so it is clear which setting this affects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzedel here :)

Ticket: MEN-7288
Changelog: Title
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
@mender-test-bot
Copy link
Contributor

mender-test-bot commented Jun 18, 2024

Merging these commits will result in the following changelog entries:

Changelogs

gui (feat/threshold-migration)

New changes in gui since master:

Features
  • added notification about changes to the device offline threshold
    (MEN-7288)

@michaelntech michaelntech self-requested a review June 18, 2024 10:18
@mzedel mzedel merged commit 064dc3e into mendersoftware:master Jun 18, 2024
3 checks passed
@mender-test-bot
Copy link
Contributor

Hello 😺 This PR contains changelog entries. Please, verify the need of backporting it to the following release branches:
3.7.x (release 3.7.x)
3.6.x (release 3.6.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants