-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEN-7288 - feat/threshold migration #4443
MEN-7288 - feat/threshold migration #4443
Conversation
mzedel
commented
Jun 5, 2024
•
edited
Loading
edited
@mzedel, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
2146d91
to
955e86f
Compare
Looks good, just would clarify the "What's changing" part. In particular what does "detected" and "any contact with Mender" mean? I would perhaps make it a bit more technical so that it's more clear. Those people reading are pretty technical anyway. :) |
@estenberg thank you for looking into this! Would the following be enough?:
|
Better, but API request can mean many things, such as the user or UI making an API request.. Perhaps "For filtering / listing which devices are offline, the data filtered on may be up to one day old. In other words, if the device has been offline for a while and only recently contacted the Mender server, it may still be listed as offline until the data filtered on is updated (within 1 day)." |
Overall I feel this was a convoluted change (long time ago), that focused more on our infra performance than how it affected the user. It is what it is now, but we need to do better next time. |
then maybe: offline devices can only be filtered for after at least one full day without any API request by a device to the Mender backend 🙃
Afaik it is a bit the other way around: if the device has been offline for a few hours it won't be listed as offline before 1 day has passed, whereas if it was offline for a while, the device coming back online will be visible right away. Here a device coming back online means: any request to the API by a device. |
I am so confused by this. :-/ |
Okey, let me try again: "If a device no longer connects with the server, it may take up to 1 day until it is shown as an offline device in the UI." |
955e86f
to
6b8b7e5
Compare
<> | ||
In our continuous efforts to enhance performance and to ensure the stability of our service, we have made adjustments to how granular device connectivity | ||
can be checked. | ||
<h4>What's Changing:</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to lowercase "c"
6b8b7e5
to
5fe9ec6
Compare
…ing days Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
5fe9ec6
to
54a0263
Compare
can be checked. | ||
<h4>What's Changing:</h4> | ||
<ul> | ||
<li>If a device no longer connects with the server, it may take up to 1 day until it is shown as an offline device in the UI.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add to the start of this line:
"Offline threshold: if a device..."
Using the same name it has in the settings, so it is clear which setting this affects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzedel here :)
Ticket: MEN-7288 Changelog: Title Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
54a0263
to
361edfe
Compare
Merging these commits will result in the following changelog entries: Changelogsgui (feat/threshold-migration)New changes in gui since master: Features
|
Hello 😺 This PR contains changelog entries. Please, verify the need of backporting it to the following release branches: |