Add spell plugin bridged to hunspell-ffi #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks sane to me. I'll go over it with Jordan tomorrow and try to get it deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Criticism welcome as always :)
NEW_ROOMS = nil in default_environment.rb is off-topic but necessary to start the bot.
HUNSPELL_DICT = '/usr/share/hunspell/en_US' - if not this, we'll need a comment explaining that anyone forking this must find the path of the .aff and .dic files in their language of choice. The default search path for the Ubuntu version of Hunspell looks for six different versions of OpenOffice, so, yeah.
I didn't limit the number of suggestion results to 10 as you're unlikely to exceed that; I'd add a limit if you only wanted the top 3.