fix hanging check_mxruntime_health nagios check #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If runtime admin port did not respond, the check would hang. Checks would keep piling up, leading to OOMing systems. This introduces a default timeout of 60 seconds. Alternatively, a ping could be done before checking the health, but a timeout is still needed for edge cases.
djvdorp
approved these changes
Mar 10, 2017
|
Thanks. Did you test this? |
|
No :'( Only in my head. |
|
Actually, this is not the only place where a timeout would be good to add. Currently if someone will damage their running app so badly that it keeps accepting connections and requests but never answer them, you're also quite out of luck with the CLI. Starting m2ee will just hang on the first runtime_status call, and you won't get your prompt to try stop the app. I'd propose to change the timeout=None in client.request(action, params, timeout) and set it to a sane low default that should be sufficient to do almost all admin actions, which should return instantly. The other ones which can take longer, like start and stop already define their custom timeouts. |
|
Moving to #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If runtime admin port did not respond, the check would hang. Checks
would keep piling up, leading to OOMing systems.
This introduces a default timeout of 60 seconds. Alternatively, a
ping could be done before checking the health, but a timeout is still
needed for edge cases.