Skip to content

Commit 276a099

Browse files
committed
fix: change aria-invalid to only show up when it's true
1 parent 8fc8fec commit 276a099

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/pluggableWidgets/combobox-web/src/components/MultiSelection/MultiSelection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ export function MultiSelection({
141141
{...inputProps}
142142
aria-labelledby={hasLabel ? inputProps["aria-labelledby"] : undefined}
143143
aria-describedby={selector.validation ? options.inputId + "-error" : undefined}
144-
aria-invalid={!!selector.validation}
144+
aria-invalid={selector.validation ? true : undefined}
145145
/>
146146
<InputPlaceholder isEmpty={selectedItems.length <= 0}>{memoizedselectedCaptions}</InputPlaceholder>
147147
</div>

packages/pluggableWidgets/combobox-web/src/components/SingleSelection/SingleSelection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export function SingleSelection({
9494
placeholder=" "
9595
aria-labelledby={hasLabel ? inputProps["aria-labelledby"] : undefined}
9696
aria-describedby={selector.validation ? options.inputId + "-error" : undefined}
97-
aria-invalid={!!selector.validation}
97+
aria-invalid={selector.validation ? true : undefined}
9898
/>
9999
<InputPlaceholder
100100
isEmpty={!selector.currentId || !selector.caption.render(selectedItem, "label")}

0 commit comments

Comments
 (0)