[WC-2511] accordion unsync content display with state #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
reviewed
Jun 28, 2024
packages/pluggableWidgets/accordion-web/src/components/AccordionGroup.tsx
Outdated
Show resolved
Hide resolved
gjulivan
force-pushed
the
WC-2511-accordion-unpredictable
branch
3 times, most recently
from
e1da1b8
to
a07ecd5
Compare
gjulivan
force-pushed
the
WC-2511-accordion-unpredictable
branch
from
a07ecd5
to
a669762
Compare
r0b1n
reviewed
Jul 12, 2024
packages/pluggableWidgets/accordion-web/src/components/AccordionGroup.tsx
Outdated
Show resolved
Hide resolved
gjulivan
force-pushed
the
WC-2511-accordion-unpredictable
branch
from
12c016d
to
883c80d
Compare
r0b1n
previously approved these changes
Jul 16, 2024
gjulivan
force-pushed
the
WC-2511-accordion-unpredictable
branch
from
37cf2f0
to
c275480
Compare
gjulivan
force-pushed
the
WC-2511-accordion-unpredictable
branch
from
c275480
to
b6d2b04
Compare
r0b1n
previously approved these changes
Jul 18, 2024
leonardomendix
approved these changes
Jul 19, 2024
r0b1n
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug Fix
Description
child content tries to expand, and calculate the content height while parent is not finished expanding.
thus, child content is still not fully visible, which cause their bounding rectangle calculation incorrect.
fixing this by adding resize observer to the content.
What should be covered while testing?
Anything related to accordion content's resizing. make sure the resize observer doesn't try to expand content while content should be collapsing