Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for repeated message fields. #2

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Conversation

mennanov
Copy link
Owner

@mennanov mennanov commented Apr 7, 2021

Add support for repeated message fields so that if given a Profile message:

message Photo {
  int64 photo_id = 1;
  string path = 2;
  Dimensions dimensions = 3;
}

message Dimensions {
  int32 width = 1;
  int32 height = 2;
}

message Profile {
  User user = 1;
  Photo photo = 2;
  repeated int64 login_timestamps = 3;
  repeated Photo gallery = 4;
}

and a mask like "gallery.photo_id", "gallery.dimensions.height" the Filter() function will keep those fields in the repeated field gallery.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #2 (a860b57) into main (9e8bf86) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           51        62   +11     
=========================================
+ Hits            51        62   +11     
Impacted Files Coverage Δ
fmutils.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8bf86...a860b57. Read the comment docs.

@mennanov mennanov self-assigned this Apr 7, 2021
@mennanov mennanov mentioned this pull request Apr 7, 2021
@SachsA SachsA merged commit a15a6f3 into main Apr 8, 2021
@SachsA
Copy link
Collaborator

SachsA commented Apr 8, 2021

Thank you for this update! It works like a charm!

@SachsA SachsA deleted the support_repeated_fields branch June 16, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants