Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always expect version to be in initial state in case key was removed #42

Merged
merged 2 commits into from
May 17, 2024

Conversation

radandrei
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.05%. Comparing base (fdeb965) to head (89c642b).

Files Patch % Lines
leakybucket.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          12       12           
  Lines        1449     1449           
=======================================
  Hits         1160     1160           
  Misses        212      212           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@mennanov mennanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сould you please add tests for this corner case?

@mennanov mennanov merged commit 6fc2031 into mennanov:master May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants