New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masked image fixes #429

Merged
merged 2 commits into from Sep 5, 2014

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Sep 5, 2014

Two bugs:

  1. Constraining mask to landmarks with existing non all-true mask. This would break due to the size of the mask.
  2. Handle NaNs when setting outside the mask colour. Make the background white.
BUG: Constrain mask to landmark with existing mask
If you had non-all-true masks and called constrain you would
fail, which was a nasty bug

@jabooth jabooth added the in progress label Sep 5, 2014

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Sep 5, 2014

@jabooth Simple fixes if you can +1

@patricksnape patricksnape force-pushed the patricksnape:masked_image_fixes branch from 1219ad1 to 55b2d46 Sep 5, 2014

@jabooth

This comment has been minimized.

Member

jabooth commented Sep 5, 2014

happy when travis is +1

jabooth added a commit that referenced this pull request Sep 5, 2014

@jabooth jabooth merged commit 11bdaf0 into menpo:master Sep 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the patricksnape:masked_image_fixes branch Sep 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment