Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masked image fixes #429

Merged
merged 2 commits into from
Sep 5, 2014
Merged

Masked image fixes #429

merged 2 commits into from
Sep 5, 2014

Conversation

patricksnape
Copy link
Contributor

Two bugs:

  1. Constraining mask to landmarks with existing non all-true mask. This would break due to the size of the mask.
  2. Handle NaNs when setting outside the mask colour. Make the background white.

@patricksnape
BUG: Constrain mask to landmark with existing mask
82025af 
If you had non-all-true masks and called constrain you would
fail, which was a nasty bug
@patricksnape
Copy link
Contributor Author

@jabooth Simple fixes if you can +1

@jabooth
Copy link
Member

jabooth commented Sep 5, 2014

happy when travis is +1

jabooth added a commit that referenced this pull request Sep 5, 2014
@jabooth
Merge pull request #429 from patricksnape/masked_image_fixes
11bdaf0 
Masked image fixes
@jabooth jabooth merged commit 11bdaf0 into menpo:master Sep 5, 2014
@jabooth jabooth deleted the masked_image_fixes branch September 5, 2014 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricksnape @jabooth