Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance CMakeLists.txt with detailed English comments for better readability #8

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

scottXchoo
Copy link
Contributor

This pull request aims to improve the readability and accessibility of the CMakeLists.txt file by adding detailed English comments. The changes include:

  1. Added comprehensive English comments explaining each section and important configuration options.
  2. Replaced existing brief or non-English comments with more descriptive English explanations.
  3. Improved overall structure and formatting for better readability.

As a developer who wishes for this open-source project to be used and appreciated by people from around the world, I have made these small but significant changes to ensure that developers from different countries can better understand the build configuration and options available in the RibbonUI project. This will also facilitate easier maintenance and future contributions to the project.

Key improvements:

  • Explained Qt package finding and version handling
  • Clarified the purpose of each build option
  • Detailed the conditional logic for macOS universal build
  • Described the QWindowKit configuration options

No functional changes have been made to the CMake configuration itself; this PR focuses solely on improving documentation and clarity.

I believe these changes will make the project more accessible to a wider audience and encourage more contributions from the global developer community.

@mentalfl0w
Copy link
Owner

Thank you very much😁!
This PR could be very useful for all developers from all over the world👍.

@mentalfl0w mentalfl0w merged commit c0a05c1 into mentalfl0w:main Jul 31, 2024
9 checks passed
@scottXchoo
Copy link
Contributor Author

Thank you very much😁! This PR could be very useful for all developers from all over the world👍.

You're welcome🤗
I hope this open source will spread to many developers, thank you so much for making this open sources~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants