Fix ext2 read and write #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename EXT2_INDIRECT_BLOCKS to EXT2_DIRECT_BLOCKS - Simplify and fix ext2_get_real_block_index - Simplify and fix ext2_read_inode_data - Remove indirect_blocks_index, doubly_indirect_blocks_index, and trebly_indirect_blocks_index from the fs structure
- We were not saving the block in ext2_set_real_block_index, now we do
- Add more comments to ext2_allocate_block; - Fix error return for ext2_read_inode_data; - Add more logging message where needed;
fischerling
reviewed
Mar 12, 2024
| @@ -817,7 +832,7 @@ static inline int ext2_find_free_block_in_group(ext2_filesystem_t *fs, uint8_t * | |||
| /// @param fs the ext2 filesystem structure. | |||
| /// @param cache the cache from which we read the bgdt data. | |||
| /// @param linear_index the output variable where we store the linear indes to the free block. | |||
| /// @return 1 if we found a free block, 0 otherwise. | |||
| /// @return 1 if we found a free block abd chace contains the block_bitmap, 0 otherwise. | |||
There was a problem hiding this comment.
This is probably a typo.
| "t_groups", | ||
| "t_itimer", | ||
| "t_kill", | ||
| // "t_abort", |
There was a problem hiding this comment.
Why disabling all tests?
There was a problem hiding this comment.
Sorry, my bad, I was disabling them to focus on write/read from file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext2_dump_inode output;EXT2_INDIRECT_BLOCKStoEXT2_DIRECT_BLOCKS;ext2_get_real_block_index;ext2_read_inode_data;indirect_blocks_index,doubly_indirect_blocks_index, andtrebly_indirect_blocks_indexfrom the fs structure;ext2_set_real_block_index, we were not saving the block inext2_set_real_block_index;ext2_write_inode_data;ext2_allocate_block;