Dev/ecip tabs #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ia <isaac.ardis@gmail.com>
Signed-off-by: ia <isaac.ardis@gmail.com>
ziogaschr
reviewed
May 20, 2022
_specs/ecip-tabs.md
Outdated
| tab += state.balance(tx.sender, block.parentHash) | ||
| } | ||
| } | ||
| return tab |
There was a problem hiding this comment.
Miner balance is gone. It was a "convenient shortcut" idea for miners originally, but I've removed it entirely now. The aggregated balance (TABS) must represent guaranteed, "proven" balance. Tallying the balance of a block's coinbase does not represent a proven, active balance.
For example, an attacker could, by modifying the coinbase of blocks they produce, cite a greater balance than actually available to them.
Instead, miners need to include valid transactions representing their own balance, if they want.
Signed-off-by: ia <isaac.ardis@gmail.com>
Signed-off-by: ia <isaac.ardis@gmail.com>
Signed-off-by: ia <isaac.ardis@gmail.com>
+ Assign Number + Add Discussion Thread
Date was stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View rendered document: https://github.com/meowsbits/ECIPs/blob/dev/ecip-tabs/_specs/ecip-tabs.md