Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin support for device types #78

Closed
Batilan opened this issue Jan 17, 2015 · 11 comments
Closed

Add plugin support for device types #78

Batilan opened this issue Jan 17, 2015 · 11 comments

Comments

@Batilan
Copy link
Contributor

Batilan commented Jan 17, 2015

@merbanan: good to see you back and active again. Thanks for this great piece of software!

Lately I have been working on a plugin infrastructure for rtl_433 so that device types can be added at runtime by simply adding or removing a library file per device type. This has been implemented and seems to be working OK. See my branch plugins at https://github.com/Batilan/rtl_433/tree/plugins.

Besides the device callbacks I'm also thinking about implementing the PWM decoders as plugins. This would allow for easier development of alternative (PWM) decoders. Currently the PWM decoders are called by all devices with different time settings for each received message. I think this can probably be made more efficient.

I think for low end devices (like Raspberry) this construct together with calling all all availabale device callbacks as is done now stresses some of these devices quite heavily already and is not really scalable if we want to add more and more devices. The factoring out of the device callbacks by @helgew is quite an improvement and makes adding devices and avoiding conflicts easier (I needed to to the same for the plugin module).

The reason I have not yet submitted a pull request is that I would like to improve the plugin interface so that it is usable in a more generic way. Also the plugin module needs some adaptions to make it work for Windows environments (is this software actually compiled and used by Windows users?). I have tested it only for different Linux environments like Raspberry and x86 distributions.

I would like to exchange some idea's and prevent duplicating of work, however a Github issue is probably not the best communication medium for this?. Lately I have also been exchanging ideas with @rct who has also been doing some nice improvements on rtl_433. I'm motivated to share idea's with any other developer that has idea's about improving the great rtl_433 software. I understand @merbanan also has idea's about improving the software but has limited time, I would like to help with structural improvements making the rtl_433 more scalable so we can remove the line "This software is mostly useable for developers right now."

Looking forward for any responses.

@merbanan
Copy link
Owner

How about starting a mailing list ? I agree on what you write. There needs to be a better "packet" format we can send to decoders, right now we are missing the length of the bits in ms, a lot of formats can be separated by that. And we need to add test recordings of the supported formats so we know when we break things or not.

@helgew
Copy link
Contributor

helgew commented Jan 17, 2015

This might work as a good place for discussions: http://www.discourse.org/ . I have not tried it myself though.

@merbanan
Copy link
Owner

I have created the google group rtl_433. Can you try it ?

@merbanan
Copy link
Owner

@merbanan
Copy link
Owner

If this works fine I'll add it on the main page.

@helgew
Copy link
Contributor

helgew commented Jan 17, 2015

Apparently, this is a closed group... not sure that's what you wanted :)

On Jan 17, 2015, at 2:11 PM, Benjamin Larsson notifications@github.com wrote:

https://groups.google.com/d/forum/rtl_433 https://groups.google.com/d/forum/rtl_433

Reply to this email directly or view it on GitHub #78 (comment).

@Batilan
Copy link
Contributor Author

Batilan commented Jan 17, 2015

I just signed up

@0xFACE
Copy link

0xFACE commented Jan 17, 2015

Works for me ;-)

@merbanan
Copy link
Owner

Soon emails may even work :)

@deennoo
Copy link
Contributor

deennoo commented Jan 24, 2015

I just signes

@merbanan
Copy link
Owner

I will close this issue. Reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants