File input fixes #1009
Merged
File input fixes #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since test_mode_buf is an array of unsigned chars, 16bit values stored to it were previously truncated to 8 bits. We fix this by type-casting the array to int16_t.
When initial scale was -1, the later condition "scale > 0" was never true. Fix this so that scale is properly computer from k/M/G prefixes.
|
Sorry, I somehow missed your PR and incidentally fixed the CF32 issue already. Thanks for fixing the scale issue. |
|
Could we have a tagged release including the cf32 fix sometime soon? (I'd like to be able to point to a compatible version number and expect it to show up in package managers, for kpreid/shinysdr#128.) |
|
@kpreid 201904 release good enough? I'd like a release before we rework the fsk decode procedure. |
|
That sounds fine. |
|
Out of curiosity, how do you plan to rework FSK decoding? I'm also playing with it to decode signal from my device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few fixes that allow me to process cf32 files.