Allow multiple filters #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasae
requested review from
andrewgy8,
daniel-ruiz and
tobami
as code owners
There was a problem hiding this comment.
What do you think about documentation? I already started with the issue, maybe you find worthy next chunk.
diff --git a/rele/subscription.py b/rele/subscription.py
index 73f6b03..3c4c276 100644
--- a/rele/subscription.py
+++ b/rele/subscription.py
@@ -139,9 +139,9 @@ def sub(topic, prefix=None, suffix=None, filter_by=None):
:param suffix: string An optional suffix to the subscription name.
Useful when you have two subscribers in the same project
that are subscribed to the same topic.
- :param filter_by: function An optional function that
- filters the messages to be processed
- by the sub regarding their attributes.
+ :param filter_by: Union[function, list] An optional function or tuple of
+ functions that filters the messages to be processed by
+ the sub regarding their attributes.
:return: :class:`~rele.subscription.Subscription`
"""
Sure. |
tobami
reviewed
Jan 10, 2020
tobami
approved these changes
Jan 10, 2020
csaroff
pushed a commit
to csaroff/rele
that referenced
this pull request
Apr 19, 2023
* Allow iterable in filter_by. * Add sad path test cases. * Beat the linter. * Update docs. * Rename setter. * Replace for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Modify subscription constructor to allow iterables in
filter_byand apply all filters.🤔 Why?
Current version only allows one filter.
🔗 Related issue
Solver #134