Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "pull_request" hook in GitHub action workflow #3357

Closed
hamidonos opened this issue Aug 13, 2024 · 0 comments · Fixed by #3419, #3432 or #3435
Closed

Enable "pull_request" hook in GitHub action workflow #3357

hamidonos opened this issue Aug 13, 2024 · 0 comments · Fixed by #3419, #3432 or #3435

Comments

@hamidonos
Copy link
Collaborator

hamidonos commented Aug 13, 2024

Situation

Currently workflow runs are not triggered if someone opens a PR on a fork.
This is because the hooks are only configured with the push event.

image

Wanted

Runs should also be triggered when someone opens a PR on SecHub (e.g. PR from a Fork)

Solution

git hub actions yaml
image

gradle yaml
image

From the official docs:

Runs your workflow anytime the pull_request event occurs. More than one activity type triggers this event. For information about the REST API, see https:// developer. github. com/ v3/ pulls. Note: Workflows do not run on private base repositories when you open a pull request from a forked repository. When you create a pull request from a forked repository to the base repository, GitHub sends the pull_request event to the base repository and no pull request events occur on the forked repository. Workflows don't run on forked repositories by default. You must enable GitHub Actions in the Actions tab of the forked repository. The permissions for the GITHUB_TOKEN in forked repositories is read-only. For more information about the GITHUB_TOKEN, see https:// help. github. com/ en/ articles/ virtual-environments-for-github-actions

hamidonos added a commit that referenced this issue Sep 10, 2024
…3419)

* implement pull request hook for gh actions

* ignore tags on push

* ignore tags on push

* ignore tags on push

* apply if condition in build step to check if branch name is matching

* added comments and renamed branch to test gha

* pr fixes

* pr fixes

* implement pull request workflow for gha action and gradle action #3357

* implement pull request workflow for gha action and gradle action #3357
hamidonos added a commit that referenced this issue Oct 10, 2024
* add spring security with oauth to web ui

* implement pull request workflow for gha action and gradle action #3357

* add mb sso to application.yml

* implement oauth config for sechub webui #3406

* make web ui spring security oidc config configurable through env variables #3406

* change variable names in application-webui_oidc.yaml

* remove webflux from web ui project

* implement success handler for redirect after successful o auth workflow in web ui

* add basic and form login to spring security in web ui

* add under construction site to web ui

* set default page to /home in webui

* update README.md in web ui

* clean up build.gradle of webui

* fix formatting in MercedesBenzOAuth2AccessTokenClient

* remove unnecessary pages and controller in webui

* exclude OAuth2Properties with @Profile

* exclude OAuth2Properties with @Profile

* pr fixes

* pr fixes

* pr fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment