Skip to content

feat: Check Re-run #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2019
Merged

feat: Check Re-run #196

merged 5 commits into from
Apr 16, 2019

Conversation

jusx
Copy link
Member

@jusx jusx commented Apr 15, 2019

Goals

Adds the ability to re-run checks:
image

Note: This PR does not address the Re-run all checks link.

Changes

  • Added interceptor middleware
  • Added check-rerun interceptor to update context during a check rerun so that validation can be run with the right payload.

@jusx jusx requested a review from shine2lay April 15, 2019 07:50
@jusx jusx added this to the Version 1.2 milestone Apr 15, 2019
@jusx jusx mentioned this pull request Apr 15, 2019
Merged
shine2lay
shine2lay reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@shine2lay shine2lay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to figure how the interceptor class is trigger the liquidators check again. could you please shed some light on it?

shine2lay
shine2lay approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@shine2lay shine2lay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, i saw that you set the event and action. that would do it i guess

@jusx
Copy link
Member Author

jusx commented Apr 16, 2019 •
edited
Loading

Yes. It's the same strategy applied with pulls and milestoned/demilestoned.

@jusx jusx merged commit c231380 into master Apr 16, 2019
@jusx jusx deleted the feat-check-rerun branch April 16, 2019 06:15
@jusx jusx mentioned this pull request Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shine2lay shine2lay shine2lay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.2
Development

Successfully merging this pull request may close these issues.

Re-run check is not working
2 participants
@jusx @shine2lay