feat: add prometheus templates for easy alerting setup #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iammuho
changed the title
iammuho
changed the title
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 92.53% 92.53%
=======================================
Files 75 75
Lines 1957 1957
Branches 399 399
=======================================
Hits 1811 1811
Misses 128 128
Partials 18 18 Continue to review full report at Codecov.
|
|
@jusx could you please review this? i don't have the expertise to review it. |
jusx
approved these changes
Jan 20, 2021
|
@iammuho Could you update this branch? Once that's done, we can merge. |
|
hey @jusx , done you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another helm template to setup prometheus alerts easily with just passing some values.