-
Notifications
You must be signed in to change notification settings - Fork 120
feat: Jira Validator Option #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jira Validator Option #483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 92.22% 92.38% +0.16%
==========================================
Files 75 76 +1
Lines 1775 1997 +222
Branches 346 410 +64
==========================================
+ Hits 1637 1845 +208
- Misses 117 133 +16
+ Partials 21 19 -2
Continue to review full report at Codecov.
|
hey @jusx any comments for this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Left a comment about the enabled suboption.
hey @jusx , you can check again. You are right, no need for enabled. |
__tests__/unit/validators/options_processor/options/jira.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iammuho Added additional comments. I would recommend including some docs either in this PR or create an issue regarding docs so that it is in the backlog.
@jusx , removed all references and sent the docs. I think in the docs we should also enable |
Issue: #482
Note: For this option to be working, options should be running on async. Before this PR to be accepted, please look at this PR: #481 (MERGED)
This PR adds a
Jira
option to the below validators. If anyone wants to check JIRA TICKET to be validated through JIRA APIs;You can use JIRA VALIDATION option in below validators;