Skip to content

Conversation

shine2lay
Copy link
Member

@shine2lay shine2lay commented Feb 22, 2021

sample config

- do: repository
        name:
          must_include:
            regex: 'my-repo-name'
          must_exclude:
            regex: 'other-repo-name'

#509 (comment)

@shine2lay shine2lay requested a review from jusx February 22, 2021 01:54
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #510 (f99e868) into master (f9f68a1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   91.71%   91.75%   +0.03%     
==========================================
  Files          98       99       +1     
  Lines        2149     2158       +9     
  Branches      404      405       +1     
==========================================
+ Hits         1971     1980       +9     
  Misses        154      154              
  Partials       24       24              
Impacted Files Coverage Δ
lib/filters/options_processor/name.js 100.00% <100.00%> (ø)
lib/filters/repository.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f68a1...f99e868. Read the comment docs.

Copy link
Member

@jusx jusx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a new feature, would it make sense to add user documentation as well?

@shine2lay
Copy link
Member Author

If this is a new feature, would it make sense to add user documentation as well?

I've already added documentation to the PR

Copy link
Member

@jusx jusx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unaware of a specific use-case where this would be useful but code wise it looks fine.

@shine2lay
Copy link
Member Author

shine2lay commented Feb 24, 2021

one use case that comes to mind where this could be useful is in org wide config file, they can have multiple generic recipes that applies to repos that includes/excludes specific names

That's the only one I can think of as well

@shine2lay shine2lay merged commit 5f27a35 into mergeability:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants