feat: add a info panel for 'limit' option in approval validator
#512
Conversation
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
==========================================
- Coverage 91.75% 91.72% -0.03%
==========================================
Files 99 99
Lines 2159 2164 +5
Branches 406 406
==========================================
+ Hits 1981 1985 +4
- Misses 154 155 +1
Partials 24 24
Continue to review full report at Codecov.
|
lib/validators/approvals.js
Outdated
| teamMembers = _.union(teamMembers, owners) | ||
| let validatorContext = { name: 'approvals' } | ||
|
|
||
| output.push(constructOutput(validatorContext, _.union(teams, owners), limitOption, {status: 'info', description: `Only the following teams and users approval will counted`})) |
There was a problem hiding this comment.
You can use "Only approvals from following sources are counted." verbiage instead
This will cover all future options in limit as well
since codeowners is also a part of limit if set to true
There was a problem hiding this comment.
Should we use _.union(teams, owners) or approvedReviewers ?
There was a problem hiding this comment.
i thought input should be a list of user that can approve it rather than the current approvedReviewers that is counted
There was a problem hiding this comment.
do you think approvedReviewers make more sense here??
There was a problem hiding this comment.
Yeah, because input is already displayed in settings field in the output
|
@jusx can you please review this? |
|
@jusx Can you please review this? |
see the discussion in #509 (comment)
output
