Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish TodoMVC example #17

Merged
merged 18 commits into from
Dec 24, 2020
Merged

Finish TodoMVC example #17

merged 18 commits into from
Dec 24, 2020

Conversation

krawaller
Copy link
Collaborator

@krawaller krawaller commented Dec 15, 2020 •
edited
Loading

Add all missing functionality in TodoMVC example, leverage the CSS.

Now it is feature complete!

image

Future work remaining:

  • More comments throughout
  • Tests

@krawaller krawaller marked this pull request as ready for review December 17, 2020 17:12
@krawaller krawaller mentioned this pull request Dec 18, 2020
Closed
@krawaller
Copy link
Collaborator Author

Whoops, seems localstorageAtom uses the verifier even when there is no stored value. I wasn't expecting that! That's what caused the null state here, and detonated in poor Billy's face.

I'll update #19 with a fix for that, and then bump klyva in this PR once that is merged and published.

@krawaller krawaller added the invalid This doesn't seem right label Dec 18, 2020
@krawaller krawaller mentioned this pull request Dec 18, 2020
Merged
@krawaller krawaller removed the invalid This doesn't seem right label Dec 18, 2020
@merisbahti
Copy link
Owner

yeehaa 🤠 use that raw klyva 0.7 power!

@krawaller krawaller merged commit 7765641 into master Dec 24, 2020
@krawaller krawaller deleted the david/todomvc branch December 24, 2020 08:42
@merisbahti
Copy link
Owner

ah, the perfect chrismas gift!! 🎁

@krawaller
Copy link
Collaborator Author

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merisbahti merisbahti merisbahti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krawaller @merisbahti