Adding mongoid support #123

jeremylynch · 2014-01-09T05:27:10Z

I have reintroduced mongoid support. It is working ~~with the exception of the top_scored method~~ .

I have tested this completely with mongoid 3.1.5 and rails 3.2.15

I could not get the mongoid-dummy app to run for some reason, I might look into this later.

Todo: update generators to work with mongoid projects.

tute · 2014-01-10T12:49:16Z

lib/merit.rb

+    @@orm = :mongoid
+  else
+    @@orm = :active_record
+  end


I don't think we need this if construct. @@orm is by default active_record, and can be overridden in the initializer.

tute · 2014-01-10T12:54:55Z

When this looks good to both of us I'll merge. I'll do it "silently" (without broadcasting in the README) cause I don't work with (and thus can't reliably maintain) other ORMs for now.
Thank you very much for your work!

Also moved common methods between AR and mongoid to a base class

jeremylynch · 2014-01-15T11:57:37Z

OK @tute check it out, updated to your needs. When you decide to merge this over, I think it would be best to broadcast it in the readme. There are Mongoid developers like myself who can keep the code updated, and if it was broadcast in the readme more mongoid developers would use it leading to further development (and bug feedback etc). Let me know if you decide to go through with this and i'll update the readme for directions on how to use the gem with mongoid.
Thanks,

tute · 2014-01-15T13:53:22Z

Looking way better! @potomak and @huacnlee will probably be interested in this PR/discussion.

Aside, would be nice to add back mongoid testing, in the form of the following block to .travis.yml, and take into account ORM specifics in test_helper.rb https://github.com/tute/merit/blob/3ee9e5830322d54db502bbf31af53c58e30b2c54/test/test_helper.rb (don't remember if anything else, probably the dummy app is old):

 env:
    - ORM=activerecord
    - ORM=mongoid

tute · 2014-01-15T13:53:51Z

lib/merit.rb

@@ -45,13 +45,17 @@ class Engine < Rails::Engine
    config.app_generators.orm Merit.orm

    initializer 'merit.controller' do |app|
+      require 'merit/models/base/base/sash'


Why base/base/? Should be merit/base/.

Agreed, ill fix this

jeremylynch · 2014-01-19T10:32:31Z

Check it out now @tute I have addressed everything you mentioned with the exception of fixing up the dummy app. Let me know your thoughts, thanks

tute · 2014-01-19T13:40:05Z

lib/merit.rb

+      require "merit/models/#{Merit.orm}/merit/activity_log"
+      require "merit/models/#{Merit.orm}/merit/badges_sash"
+      require "merit/models/#{Merit.orm}/merit/sash"
+      require "merit/models/#{Merit.orm}/merit/score"


tute · 2014-01-19T14:29:57Z

Looking great, we are very close! Dummy app should be fixed, I can do it after merge I guess.

Can you please rebase on top of current master, so it's mergeable again?

Left a few comments, as always, thank you very much for your work!

tute · 2014-01-21T14:26:52Z

lib/merit/models/mongoid/merit/activity_log.rb

+
+    belongs_to :action, class_name: 'Merit::Action'
+    belongs_to :related_change, polymorphic: true
+


Tiny comments (ok to ignore): stray newline.

jeremylynch · 2014-01-28T13:03:05Z

Take a look @tute, let me know what you think and we can look at rebasing if you think that it's ready

tute · 2014-01-28T14:41:29Z

lib/merit.rb

+      require "merit/models/#{Merit.orm}/merit/activity_log"
+      require "merit/models/#{Merit.orm}/merit/badges_sash"
+      require "merit/models/#{Merit.orm}/merit/sash"
+      require "merit/models/#{Merit.orm}/merit/score"


tute · 2014-01-28T14:51:03Z

lib/merit/models/mongoid/merit/sash.rb

+    include Mongoid::Timestamps
+    include Base::Sash
+
+    belongs_to :user, class_name: 'User'


A Sash belongs to a "meritable model", which happens to be User many times, but it's not always the case. We should be able to attach sashes to any model in the app, this won't pass the "dummy app" tests, where comments also hold reputation.

tute · 2014-01-28T14:53:51Z

Looking really good! Should we pair to wrap it up? Specially the test app. We should decide how to attach sashes to arbitrary models in Mongoid first.

Added observer to Merit.

Adds test assertions.

jeremylynch · 2014-02-04T01:52:09Z

Sorry @tute. Yes lets wrap this up. We could always make a one sided relationship, so @user.sash => sash and @comment.sash => sash while @sash.user => undefined
To do this we would just need to remove the belongs_to :user from the sash modal

tute · 2014-02-04T02:17:55Z

It seems AR doesn't have the Sash.belongs_to (https://github.com/tute/merit/blob/master/lib/merit/models/active_record/merit/sash.rb), so it should be fine. If we remove it, and rebase history on top of master, I can take care of the testing through the dummy app. Thank you!

Also moved common methods between AR and mongoid to a base class

jeremylynch · 2014-02-04T02:44:20Z

Ok, have a look @tute, I've rebased on master, I think it should be ready to pull

tute · 2014-02-04T02:55:06Z

Thanks @mrjlynch. Though you may have rebased with master on your repository, you need to fetch from tute/merit. It seems that you rebased with a commit from December but there's new changes: https://github.com/tute/merit/commits/master.
Thank you!

tute · 2014-02-04T02:56:26Z

There's actually duplicate commits, and a merge. I'll do it myself, and fix the tests. Thanks a lot!

Adding mongoid support

tute · 2014-02-04T02:58:30Z

Merged from the command line, thanks for your help! :)

jeremylynch · 2014-02-04T03:17:24Z

Great, Thanks Tute!

jeremylynch · 2014-02-04T03:19:09Z

Can we also update the readme?

tute · 2014-02-04T04:48:54Z

Can't make it work @mrjlynch, and got late. If you want to fix tests in current master ($ ORM=mongoid rake, added necessary infrastructure), you are very welcome!

For now, code seems closer to work with mongoid, but won't update the README until it works well. Thanks for the work!

tagrudev · 2014-05-21T11:27:09Z

any progress ?

jeremylynch · 2014-09-08T07:08:59Z

@tagrudev I am no longer using this gem with mongoid, everything should work though, the specs just don't pass. Feel free to update them.

ajpauwels · 2014-09-25T17:07:50Z

@mrjlynch @tute I can't seem to get Merit to install on a Mongoid setup. rails g merit:install gives module:Merit': uninitialized constant Merit::ActiveRecord (NameError)`

I went into /lib/merit.rb, commented out @config.orm || :active_record and replaced it with @config.orm = :mongoid.

The install went through this time as far as copying over the files, but it gave an error mongoid [not found].

However, I went into the rails console and created a Badge which went through fine, and then added that Badge to my user which also seems to have succeeded:

2.1.2 :007 > @user.add_badge(1)
 => #<Merit::BadgesSash _id: 54244b2b616c651989000000, created_at: 2014-09-25 17:04:43 UTC, updated_at: 2014-09-25 17:04:43 UTC, sash_id: BSON::ObjectId('542447e0616c651960000000'), badge_id: 1>

I can do @user.badges just fine, it'll return the badge. However, when I try to use @user.rm_badge(1), the function returns => true but when I do @user.badges, the old badge still shows up.

Any suggestions?

UPDATE: So it seems that the badge is removed, but that change isn't reflected immediately in @user. If I remove the badge, set @user = nil, get it again with @user = User.first, and then do @user.badges, the array is empty.

I apologize for my ignorance, but is this expected behavior?

tute · 2014-09-25T19:11:32Z

You can also do @user.reload and see the change, indeed it is expected.

Though to be 100% sure that it works in mongoid, a Pull Request that reenables CI and gets it green would be needed. See: https://github.com/tute/merit/blob/master/.travis.yml#L14-L16.

nahankid · 2015-03-01T20:36:10Z

I still can't get merit to work with only mongoid. Here are the issues I run into:

When I run rails g merit:install, it gives me `module:Merit': uninitialized constant Merit::ActiveRecord (NameError)
After adding merit.rb in config/initializers, with config.orm:mongoid, i can get past rails g merit:install but it still generates some migrations. It generates mongoid models too. Why AR migrations at all?

Adding mongoid support

82165c2

jeremylynch mentioned this pull request Jan 9, 2014

Mongoid support #12

Closed

adding top_scored method

c36b0bf

tute reviewed Jan 10, 2014
View reviewed changes

Moved activityLog, BadgesSash & Sash to mongoid/merit

a4be99b

Also moved common methods between AR and mongoid to a base class

tute reviewed Jan 15, 2014
View reviewed changes

Cleaning up

ed0037c

tute reviewed Jan 19, 2014
View reviewed changes

tute reviewed Jan 21, 2014
View reviewed changes

Finishing up

b65ef35

tute reviewed Jan 28, 2014
View reviewed changes

tute added 3 commits January 30, 2014 10:36

Merge pull request #128 from marcinsklodowski/observer-the-real-one

47377d2

Added observer to Merit.

Improves Observer API. Adds documentation.

e5e75da

Implements some rubocop suggestions.

cae0436

Adds test assertions.

Jeremy Lynch added 8 commits February 4, 2014 12:25

Last changes

b5627a9

Adding mongoid support

0085862

adding top_scored method

650c2df

Moved activityLog, BadgesSash & Sash to mongoid/merit

1334190

Also moved common methods between AR and mongoid to a base class

Cleaning up

44d83d1

Finishing up

095c85c

Last changes

72647a3

Rebasing on master

9b748cf

tute added a commit that referenced this pull request Feb 4, 2014

Merge pull request #123 from mrjlynch/master

7b8e557

Adding mongoid support

tute closed this Feb 4, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding mongoid support #123

Adding mongoid support #123

jeremylynch commented Jan 9, 2014

tute Jan 10, 2014

tute commented Jan 10, 2014

jeremylynch commented Jan 15, 2014

tute commented Jan 15, 2014

tute Jan 15, 2014

jeremylynch Jan 15, 2014

jeremylynch commented Jan 19, 2014

tute Jan 19, 2014

tute commented Jan 19, 2014

tute Jan 21, 2014

jeremylynch commented Jan 28, 2014

tute Jan 28, 2014

tute Jan 28, 2014

tute commented Jan 28, 2014

jeremylynch commented Feb 4, 2014

tute commented Feb 4, 2014

jeremylynch commented Feb 4, 2014

tute commented Feb 4, 2014

tute commented Feb 4, 2014

tute commented Feb 4, 2014

jeremylynch commented Feb 4, 2014

jeremylynch commented Feb 4, 2014

tute commented Feb 4, 2014

tagrudev commented May 21, 2014

jeremylynch commented Sep 8, 2014

ajpauwels commented Sep 25, 2014

tute commented Sep 25, 2014

nahankid commented Mar 1, 2015


		belongs_to :action, class_name: 'Merit::Action'
		belongs_to :related_change, polymorphic: true

Adding mongoid support #123

Adding mongoid support #123

Conversation

jeremylynch commented Jan 9, 2014

tute Jan 10, 2014

Choose a reason for hiding this comment

tute commented Jan 10, 2014

jeremylynch commented Jan 15, 2014

tute commented Jan 15, 2014

tute Jan 15, 2014

Choose a reason for hiding this comment

jeremylynch Jan 15, 2014

Choose a reason for hiding this comment

jeremylynch commented Jan 19, 2014

tute Jan 19, 2014

Choose a reason for hiding this comment

tute commented Jan 19, 2014

tute Jan 21, 2014

Choose a reason for hiding this comment

jeremylynch commented Jan 28, 2014

tute Jan 28, 2014

Choose a reason for hiding this comment

tute Jan 28, 2014

Choose a reason for hiding this comment

tute commented Jan 28, 2014

jeremylynch commented Feb 4, 2014

tute commented Feb 4, 2014

jeremylynch commented Feb 4, 2014

tute commented Feb 4, 2014

tute commented Feb 4, 2014

tute commented Feb 4, 2014

jeremylynch commented Feb 4, 2014

jeremylynch commented Feb 4, 2014

tute commented Feb 4, 2014

tagrudev commented May 21, 2014

jeremylynch commented Sep 8, 2014

ajpauwels commented Sep 25, 2014

tute commented Sep 25, 2014

nahankid commented Mar 1, 2015