Make Sash optional dependency #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redtachyons
changed the title
|
ping @tute |
|
Hey! Thank you for your input and work on this. I’m now on a long trip on
remote lands, no wifi or computer available. Apologies for the delay, will
be able to review in a few weeks. Thanks again!
…On Thursday, February 15, 2018, Aboobacker MK ***@***.***> wrote:
ping @tute <https://github.com/tute>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#287 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADT9FWv25-qZ05tdgvm6auRsTIMExLNks5tVB3QgaJpZM4SE2nM>
.
|
|
As a follow up, I forked this with @redtachyons's tweak and it solves the issue well. |
|
Thanks for the reminder, I'm back online! :-) @redtachyons apologies I haven't been able to work on this before. Do you think you can add a regression test for Rails 5.1? Thank you! |
|
@tute Actually...I say that. It actually doesn't seem to be working when creating a new user.
That doesn't do anything on create. |
|
Basically the same thing mentioned in #285. |
Closed
|
@tute Will try to add a regression test this weekend |
Rails 5.1 and above add automatic validation for belongs_to association. It is enabled by an initializer added to new projects. Adding that configuartion in dummy app will reproduce the issue in test case
redtachyons
changed the title
|
@tute done |
|
Wonderful, thank you! 😃 👏 |
|
Released version 3.0.2 with this fix: https://github.com/merit-gem/merit/releases/tag/v3.0.2 Thank you all again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.1 + add presence validation for belongs_to by default
Fixes #286