-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowchart doesn't allow "call" in node text #2495
Comments
Is there still no fix for this? This #2388 seems to be fixed by putting the reserved word inside a name for that node. i.e. But for |
Examples for testing: I see in a flowchart LR, in VS Code, plugin "Markdown Preview Mermaid Support" 1.15.3 (changelog indicates "Pick up mermaid 9.2.2")
|
In case anybody is looking for a workaround, putting text in quotes works fine:
|
Closing this one in favor of #4645 |
Fixes catchpoint#76 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Fixes catchpoint#76 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
[ upstream commit 9592c69 ] Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 9592c69 ] Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 9592c69 ] Basically, workflow telemetry uses step names for gantt charts which uses Github's native support for mermaidjs for rendering the charts in issues and PRs. However mermaidjs has an issue (mermaid-js/mermaid#2495) when you use mermaid reserved keywords in node names/text. To fix rendering of the ipsec upgrade workflow's telemetry, avoid the use of the "call" keyword. This is a work around for catchpoint/workflow-telemetry-action#76. If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names. Fixes #32241 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Describe the bug
This works:
This doesn't:
Bug initially confirmed in mmdc. Confirmed on mermaid.live
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Any text should be rendered,
Screenshots
If applicable, add screenshots to help explain your problem.
Code Sample
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: