Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowchart doesn't allow "call" in node text #2495

Closed
Duberry opened this issue Nov 17, 2021 · 4 comments
Closed

Flowchart doesn't allow "call" in node text #2495

Duberry opened this issue Nov 17, 2021 · 4 comments
Labels
Contributor needed Graph: Flow roadmap items to add to roadmap for auto workflow Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@Duberry
Copy link

Duberry commented Nov 17, 2021

Describe the bug

This works:

graph TD
testthing[this is a <br>thing]

    A[Christmas] -->|Get money| B(Go shopping)
    B --> testthing
    C -->|One| D[Laptop]
    C -->|Two| E[iPhone]
    C -->|Three| F[fa:fa-car Car]

This doesn't:

graph TD
testthing[this is a call <br>thing]

    A[Christmas] -->|Get money| B(Go shopping)
    B --> testthing
    C -->|One| D[Laptop]
    C -->|Two| E[iPhone]
    C -->|Three| F[fa:fa-car Car]

Bug initially confirmed in mmdc. Confirmed on mermaid.live

To Reproduce
Steps to reproduce the behavior:

  1. Write diagram
  2. include the word 'call' in a named object
  3. Experience syntax error

Expected behavior
Any text should be rendered,

Screenshots
If applicable, add screenshots to help explain your problem.

Code Sample

graph TD
testthing[this is a call <br>thing]

    A[Christmas] -->|Get money| B(Go shopping)
    B --> testthing
    C -->|One| D[Laptop]
    C -->|Two| E[iPhone]
    C -->|Three| F[fa:fa-car Car]

Desktop (please complete the following information):

  • Version
  • 8.13.3
@Duberry Duberry added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Nov 17, 2021
@Yash-Singh1 Yash-Singh1 changed the title Mermaid incorrect Syntax error when word 'call' used inside object (flow Flowchart doesn't allow "call" in node text Nov 17, 2021
@Yash-Singh1 Yash-Singh1 added Graph: Flow Status: Approved Is ready to be worked on and removed Status: Triage Needs to be verified, categorized, etc labels Nov 17, 2021
@Ar-Kareem
Copy link

Is there still no fix for this?

This #2388 seems to be fixed by putting the reserved word inside a name for that node. i.e. id[foo_default] instead of foo_default

But for call this doesn't seem to work. i.e. id[call api] and call api both break

@MisterScott
Copy link

MisterScott commented Jan 18, 2023

Examples for testing: I see in a flowchart LR, in VS Code, plugin "Markdown Preview Mermaid Support" 1.15.3 (changelog indicates "Pick up mermaid 9.2.2")

  1. "calls" (append a letter) works, e.g. pA-->|correct calls |M
  2. "call" at the END is OK, e.g. pA-->|correct call|M
  3. "call " (append a space) fails, e.g. pA-->|correct call |M
  4. "call;" (append a semicolon) fails, e.g. pA-->|correct call;|M
  5. "call:" (append a colon) works, e.g. pA-->|correct call:|M
  6. "call<br>" (append an HTML tag, at least for <br>) works, e.g. pA-->|correct call<br>x|M

@tabasavr
Copy link

tabasavr commented May 6, 2023

In case anybody is looking for a workaround, putting text in quotes works fine:

flowchart TD
   aaa["quoted text can contain call without any problems"]

@nirname
Copy link
Contributor

nirname commented Jul 16, 2023

Closing this one in favor of #4645

@nirname nirname closed this as completed Jul 16, 2023
@nirname nirname added the roadmap items to add to roadmap for auto workflow label Jul 16, 2023
chancez added a commit to chancez/workflow-telemetry-action that referenced this issue Jul 23, 2024
Fixes catchpoint#76

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez added a commit to chancez/workflow-telemetry-action that referenced this issue Jul 24, 2024
Fixes catchpoint#76

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez added a commit to cilium/cilium that referenced this issue Jul 30, 2024
Basically, workflow telemetry uses step names for gantt charts which
uses Github's native support for mermaidjs for rendering the charts in
issues and PRs. However mermaidjs has an issue
(mermaid-js/mermaid#2495) when you use
mermaid reserved keywords in node names/text.

To fix rendering of the ipsec upgrade workflow's telemetry, avoid the
use of the "call" keyword.

This is a work around for catchpoint/workflow-telemetry-action#76.
If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names.

Fixes #32241

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
github-merge-queue bot pushed a commit to cilium/cilium that referenced this issue Jul 31, 2024
Basically, workflow telemetry uses step names for gantt charts which
uses Github's native support for mermaidjs for rendering the charts in
issues and PRs. However mermaidjs has an issue
(mermaid-js/mermaid#2495) when you use
mermaid reserved keywords in node names/text.

To fix rendering of the ipsec upgrade workflow's telemetry, avoid the
use of the "call" keyword.

This is a work around for catchpoint/workflow-telemetry-action#76.
If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names.

Fixes #32241

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
nbusseneau pushed a commit to cilium/cilium that referenced this issue Aug 3, 2024
[ upstream commit 9592c69 ]

Basically, workflow telemetry uses step names for gantt charts which
uses Github's native support for mermaidjs for rendering the charts in
issues and PRs. However mermaidjs has an issue
(mermaid-js/mermaid#2495) when you use
mermaid reserved keywords in node names/text.

To fix rendering of the ipsec upgrade workflow's telemetry, avoid the
use of the "call" keyword.

This is a work around for catchpoint/workflow-telemetry-action#76.
If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names.

Fixes #32241

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau pushed a commit to cilium/cilium that referenced this issue Aug 3, 2024
[ upstream commit 9592c69 ]

Basically, workflow telemetry uses step names for gantt charts which
uses Github's native support for mermaidjs for rendering the charts in
issues and PRs. However mermaidjs has an issue
(mermaid-js/mermaid#2495) when you use
mermaid reserved keywords in node names/text.

To fix rendering of the ipsec upgrade workflow's telemetry, avoid the
use of the "call" keyword.

This is a work around for catchpoint/workflow-telemetry-action#76.
If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names.

Fixes #32241

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
gandro pushed a commit to cilium/cilium that referenced this issue Aug 6, 2024
[ upstream commit 9592c69 ]

Basically, workflow telemetry uses step names for gantt charts which
uses Github's native support for mermaidjs for rendering the charts in
issues and PRs. However mermaidjs has an issue
(mermaid-js/mermaid#2495) when you use
mermaid reserved keywords in node names/text.

To fix rendering of the ipsec upgrade workflow's telemetry, avoid the
use of the "call" keyword.

This is a work around for catchpoint/workflow-telemetry-action#76.
If an when catchpoint/workflow-telemetry-action#77 is merged, we do not need to be concerned with workflow step names.

Fixes #32241

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor needed Graph: Flow roadmap items to add to roadmap for auto workflow Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

7 participants