Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error not shown in v10 #4256

Closed
sidharthv96 opened this issue Mar 30, 2023 · 1 comment · Fixed by #4258
Closed

Error not shown in v10 #4256

sidharthv96 opened this issue Mar 30, 2023 · 1 comment · Fixed by #4258
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@sidharthv96
Copy link
Member 

erDiagram
  ATLAS-ORGANIZATION ||--|{ ATLAS-PROJECTS : "has many"
  ATLAS-PROJECTS ||--|{ MONGODB-CLUSTERS : "has many"
  ATLAS-PROJECTS ||--|{ ATLAS-TEAMS : "has many"
  MONGODB-CLUSTERS ||..|{
  ATLAS-TEAMS ||..|{

In v8
Screen Shot 2023-03-27 at 5 00 02 PM

If I change the version to @9, I get this error message:
Screen Shot 2023-03-27 at 4 07 57 PM

If I change it to @10, I get just blank white space where the diagram would be.

Originally posted by @celinehaddad in #4251
@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Mar 30, 2023
@sidharthv96
Copy link
Member Author 

erDiagram
  ATLAS-ORGANIZATION ||--|{ ATLAS-PROJECTS : "has many"
  ATLAS-PROJECTS ||--|{ MONGODB-CLUSTERS : "has many"
  ATLAS-PROJECTS ||--|{ ATLAS-TEAMS : "has many"

image

@celinehaddad, I think the last 2 lines were the issue.
Removing that renders the diagram in v10.

But the error message not showing in v10 is still an issue.

@sidharthv96 sidharthv96 changed the title erDiagram broken from v9+ Error not shown in v10 Mar 30, 2023
sidharthv96 added a commit that referenced this issue Mar 30, 2023
@sidharthv96
fix(#4256): Keep error diagram on screen
46ab6f4
@sidharthv96 sidharthv96 mentioned this issue Mar 30, 2023
Merged
4 tasks
knsv added a commit that referenced this issue Mar 31, 2023
@knsv
Merge pull request #4258 from mermaid-js/sidv/fix/4256
c4e4efd 
fix(#4256): Keep error diagram on screen
sidharthv96 added a commit that referenced this issue Apr 5, 2023
@sidharthv96
Merge branch 'develop' into sidv/addUMD
ca8ce82 
* develop: (81 commits)
  revert pnpm changes
  doc update
  auto generated from pnpm run
  auto generated from pnpm run
  linting
  added example of Bar chart
  Update docs
  Adding rendering tests and unit tests
  Syntax for markdown strings is a single backtick.
  updated labels in the chart
  Update docs
  updated example data smaller
  Bar chart
  fix: Remove comment line completely
  fix: trimStart to text
  test: add space before init
  fix uncaughexception in tests
  fix(#4256): Keep error diagram on screen
  fix(#4137): Cleanup comments before parsing
  Update docs
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#4256): Keep error diagram on screen mermaid-js/mermaid
1 participant
@sidharthv96