Feature/1048 Build workflows #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Actions is quite faster than travis. 4-5 min vs 8 min. However, currently without percy. Wondering if that matters. |
|
So, it turns out the release workflow will need some more work to get it done properly. For now I would like to get the build pipelines with GitHub Actions running. Then I can draft the release workflow while we can test the build action. |
|
Want to implement caching afterwards this can be merged. |
|
Caching is now build in. Build times are reduced to approx. 4 minutes. Also updated jest and it's dependencies to the latest versions. |
knsv
reviewed
Nov 19, 2019
knsv
approved these changes
Nov 19, 2019
|
Will remove them and have a look what happens. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1048
Added workflow for build.
In order to get coveralls working, according to their docs there need to be specified 2 secrets:
COVERALLS_SERVICE_NAME(the name of your build system)COVERALLS_REPO_TOKEN(the secret repo token from coveralls.io)In order to allow publishing to npm, there needs to be another secret (e.g.
NPM_TOKEN) containing an api key with according permissions.