Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the System_Boundary stereotype #5243

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

jonmcewen
Copy link
Contributor

📑 Summary

Trivial change to correct the [ENTERPRISE] stereotype label to [SYSTEM] for C4 System_Boundary.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit c468319
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66743e55bddcdd0008c784f2
😎 Deploy Preview https://deploy-preview-5243--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.73%. Comparing base (4b21e1e) to head (c468319).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5243   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          278     277    -1     
  Lines        41999   41988   -11     
  Branches       490     515   +25     
=======================================
  Hits          2409    2409           
+ Misses       39590   39579   -11     
Flag Coverage Δ
unit 5.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@sidharthv96
Copy link
Member

@mermaid-js/atlantians can someone familiar with C4 review?

@jonmcewen
Copy link
Contributor Author

@mermaid-js/atlantians can someone familiar with C4 review?

@mermaid-js/atlantians this should be a quick-win review for someone with a minute to spare please!

Copy link
Member

@Yash-Singh1 Yash-Singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mermaid-js/atlantians can someone familiar with C4 review?

I haven't worked on the C4 Diagram, but this fixes the example case in docs to have a system boundary labelled correctly on BankBoundary2. Earlier it was labelled as enterprise boundary.

@nirname
Copy link
Contributor

nirname commented May 29, 2024

I haven't worked with C4 either, but this seems to be an obvious fix

@nirname nirname enabled auto-merge May 29, 2024 22:57
@nirname nirname disabled auto-merge May 29, 2024 22:57
@nirname nirname self-assigned this Jun 20, 2024
Copy link

argos-ci bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jun 20, 2024, 2:48 PM

@nirname nirname added this pull request to the merge queue Jun 20, 2024
Merged via the queue into mermaid-js:develop with commit d95c159 Jun 20, 2024
19 checks passed
Copy link

mermaid-bot bot commented Jun 20, 2024

@jonmcewen, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants