Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Requirement overflow #5305

Merged

Conversation

Mikek16
Copy link
Contributor

@Mikek16 Mikek16 commented Feb 21, 2024

📑 Summary

Changes the charLimit for text wrapping in the requirementRenderer.js from 30 to 24 to stop overflowing.

Resolves #2477

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 22168ed
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c44c2bb2dd7b0008bdcd1f
😎 Deploy Preview https://deploy-preview-5305--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Feb 21, 2024
@Mikek16
Copy link
Contributor Author

Mikek16 commented Feb 21, 2024

Updated:
working2477

Original:
original2477

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 5.22%. Comparing base (6205ddd) to head (22168ed).
Report is 9 commits behind head on develop.

Files Patch % Lines
...id/src/diagrams/requirement/requirementRenderer.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5305      +/-   ##
==========================================
- Coverage     5.22%   5.22%   -0.01%     
==========================================
  Files          322     323       +1     
  Lines        46201   46212      +11     
  Branches       561     537      -24     
==========================================
  Hits          2415    2415              
- Misses       43786   43797      +11     
Flag Coverage Δ
unit 5.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...id/src/diagrams/requirement/requirementRenderer.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@Mikek16 Mikek16 marked this pull request as ready for review February 25, 2024 01:02
Copy link

argos-ci bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 47 changed Aug 20, 2024, 8:08 AM

@sidharthv96 sidharthv96 merged commit d5432ce into mermaid-js:develop Aug 20, 2024
19 of 20 checks passed
Copy link

mermaid-bot bot commented Aug 20, 2024

@Mikek16, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

sidharthv96 added a commit that referenced this pull request Aug 20, 2024
As it doesn't fix the issue in all cases.
@sidharthv96
Copy link
Member

I had to revert this change in 4e7d650, as the fix doesn't solve overflow in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement Diagram:-If text is long it is going out of box
2 participants