Improve CLI output #536
Merged
Improve CLI output #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gibson042
commented
May 25, 2017
gibson042
commented
- Always use verbosity-aware CLI logging
- Include file paths in CLI log output
gibson042
commented
May 25, 2017
| @@ -75,7 +75,7 @@ files.forEach(function (file) { | |||
| var oDOM | |||
| var svgContent | |||
|
|
|||
| console.log('ready to execute png: ' + filename + '.png ') | |||
| log('ready to execute: ' + file) | |||
There was a problem hiding this comment.
Note that this change makes execution completely silent without --verbose. If that's undesirable, we could use console.log for "ready to execute" and "saved" messages.
|
Do you know why Travis CI build failed? It was OK: https://travis-ci.org/knsv/mermaid/builds/225268042 |
|
Ugh, it's the thing I had to update for running tests locally:
Fixed now (I hope). |
|
It failed again, but this one is probably out of my hands:
|
|
Nevermind, I fixed it per Travis CI documentation. 🙌 |
mgenereu
pushed a commit
to mgenereu/mermaid
that referenced
this pull request
Jun 25, 2022
Bumps [@sveltejs/adapter-static](https://github.com/sveltejs/kit/tree/HEAD/packages/adapter-static) from 1.0.0-next.21 to 1.0.0-next.22. - [Release notes](https://github.com/sveltejs/kit/releases) - [Changelog](https://github.com/sveltejs/kit/blob/master/packages/adapter-static/CHANGELOG.md) - [Commits](https://github.com/sveltejs/kit/commits/HEAD/packages/adapter-static) --- updated-dependencies: - dependency-name: "@sveltejs/adapter-static" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.