Convert gitGraph to TS #5407
Convert gitGraph to TS #5407
Conversation
❌ Deploy Preview for mermaid-js failed.
|
|
@sidharthv96 Hey sidharth would you know if this .hash is used? I don't see this for other diagrams so I have a feeling this is legacy code that I can remove mermaid/packages/mermaid/src/diagrams/git/gitGraphAst.ts Lines 214 to 221 in d464a6b |
|
Yes, you can remove that hash. |
There was a problem hiding this comment.
Awesome work so far @NicolasCwy 🚀
Some minor comments regarding the conventions.
| const orderInt = parseInt(order, 10); | ||
| if (isNaN(orderInt)) { | ||
| throw new Error('Invalid order provided'); | ||
| // TODO - what is this hash? |
There was a problem hiding this comment.
The hash is used in external apps like the live editor to show more info about an error.
There was a problem hiding this comment.
Oh so in your previous comment about removing that hash, you didn't mean that I can remove all the hashes?
There was a problem hiding this comment.
Bump on this @sidharthv96
There was a problem hiding this comment.
You can remove the ones that are incorrect/filled with dummy data. It would be better if you can put the right data in, but I don't think that's available in the DB. (line position and all)
| 'merge ' + | ||
| otherBranchName + | ||
| ' ' + | ||
| custom_id + | ||
| '_UNIQUE ' + | ||
| override_type + | ||
| ' ' + | ||
| custom_tag, |
There was a problem hiding this comment.
Please use string template instead.
|
@sidharthv96 Can the old git graph renderer be removed? I don't see any references to it |
📑 Summary
Brief description about the content of your PR.
Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch