-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SequenceDiagram: draw activations even without explicit deactivation #5457
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5457 +/- ##
==========================================
- Coverage 5.72% 5.72% -0.01%
==========================================
Files 278 277 -1
Lines 42013 42019 +6
Branches 490 515 +25
==========================================
Hits 2407 2407
- Misses 39606 39612 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dansseg, can you please add integration tests to cover all the cases that you are expecting this to fix?
The implementation seems to be working for some cases I tested.
File: cypress/integration/rendering/sequencediagram.spec.js
📑 Summary
Activations will now also be drawn, even if there is no deactivation for a participant. The activation will reach down to the bottom or to the point where the participant gets destroyed.
Resolves #3849
📏 Design Decisions
All activations were already parsed correctly and stored in 'bounds.activations'. If no deactivation was existing, it would remain inside this array. This information is now used to draw the 'missing' activations after all actors and messages were drawn already.
If an actor was destroyed, it's last y position is also stored already (
bounds.models.actors[].stopy
), which will then be used as the end of the activation, instead of the end of the diagram.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch