Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simply from and to in message to string type #5471

Merged
merged 4 commits into from
May 1, 2024

Conversation

ad1992
Copy link
Contributor

@ad1992 ad1992 commented Apr 18, 2024

📑 Summary

Change the type of from and to to string

Before

from?: { actor: string };
to?: { actor: string };

Now

from?:  string;
to?:string;

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit e102ac2
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66327cc09506260008c952a2
😎 Deploy Preview https://deploy-preview-5471--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 5.73%. Comparing base (8265e53) to head (e102ac2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5471   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          277     277           
  Lines        42002   41999    -3     
  Branches       515     515           
=======================================
  Hits          2407    2407           
+ Misses       39595   39592    -3     
Flag Coverage Δ
unit 5.73% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/mermaid/src/diagrams/sequence/sequenceDb.ts 0.00% <0.00%> (ø)
.../mermaid/src/diagrams/sequence/sequenceRenderer.ts 0.00% <0.00%> (ø)

@ad1992
Copy link
Contributor Author

ad1992 commented Apr 18, 2024

@sidharthv96 let me know if this looks good

@sidharthv96 sidharthv96 enabled auto-merge May 1, 2024 17:32
@sidharthv96 sidharthv96 added this pull request to the merge queue May 1, 2024
@sidharthv96 sidharthv96 removed this pull request from the merge queue due to a manual request May 1, 2024
@sidharthv96 sidharthv96 enabled auto-merge May 1, 2024 17:32
@sidharthv96 sidharthv96 added this pull request to the merge queue May 1, 2024
Merged via the queue into mermaid-js:develop with commit e68125e May 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants