Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: make sequence/svgDraw typesafe #5484

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

ad1992
Copy link
Contributor

@ad1992 ad1992 commented Apr 23, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit c5b3535
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/662793e123f18e00081b97f7
😎 Deploy Preview https://deploy-preview-5484--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 360 lines in your changes are missing coverage. Please review.

Project coverage is 5.71%. Comparing base (3809732) to head (c5b3535).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5484      +/-   ##
==========================================
- Coverage     5.72%   5.71%   -0.01%     
==========================================
  Files          278     277       -1     
  Lines        42013   42083      +70     
  Branches       490     515      +25     
==========================================
  Hits          2407    2407              
- Misses       39606   39676      +70     
Flag Coverage Δ
unit 5.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../mermaid/src/diagrams/sequence/sequenceRenderer.ts 0.00% <0.00%> (ø)
...kages/mermaid/src/diagrams/common/svgDrawCommon.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/sequence/svgDraw.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@ad1992 ad1992 changed the title refactor: make sequence/svgDraw typesafe [WIP] refactor: make sequence/svgDraw typesafe Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant