fix(eslint-plugin): support JSX attrs in allowTypedFunctionExpressions #2
Conversation
merrywhether
force-pushed
the
explicit-return-type-jsx
branch
from
75d92f7
to
dae81ed
Compare
| * foo(() => 1) | ||
| * ``` | ||
| */ | ||
| function isFunctionArgument( |
There was a problem hiding this comment.
Moved to be with siblings
| * <Comp x={...} /> | ||
| * ``` | ||
| */ | ||
| function isJSXAttribute( |
There was a problem hiding this comment.
Open to feedback on the name here.
| */ | ||
| function isJSXAttribute( | ||
| node: TSESTree.Node, | ||
| ): node is TSESTree.JSXExpressionContainer | TSESTree.JSXSpreadAttribute { |
There was a problem hiding this comment.
It seems like this (and the others) could just be boolean (especially the ones that are asserting more than just a type).
| node: TSESTree.Node, | ||
| ): node is TSESTree.JSXExpressionContainer | TSESTree.JSXSpreadAttribute { | ||
| return ( | ||
| node.type === AST_NODE_TYPES.JSXExpressionContainer || |
There was a problem hiding this comment.
This is technically the RHS of a JSXAttribute, so this check could also recurse one level higher if that is preferred. This should be the only way to have a function supplied in JSX though.
| ); | ||
| } | ||
|
|
||
| function isTypedParent( |
There was a problem hiding this comment.
Created a wrapping function for these to make it deduplicate between the common case and recursive object-property case. Open to feedback on the name here.
| isPropertyOfObjectWithType(parent) || | ||
| isFunctionArgument(parent, node) || | ||
| isConstructorArgument(parent) |
There was a problem hiding this comment.
DRYing these out, it makes it more obvious that the recursive object-property doesn't include this base case, but it seems like it should?
Happy to move it into isTypedParent() if this is indeed a bug.
| { | ||
| code: ` | ||
| const Comp: FC = () => { | ||
| return <button {...{ onClick: () => {} }} />; |
There was a problem hiding this comment.
This is a cursed pattern but included for completeness.
merrywhether
changed the title
TEMPORARY FORK PR for demo and notes
Addresses typescript-eslint#7552
https://typescript-eslint.io/contributing/pull-requests
PR Checklist
allowTypedFunctionExpressionsoption should be aware of JSX typescript-eslint/typescript-eslint#7552Overview
allowTypedFunctionExpressionsoption of theexplicit-function-return-typerule