Build system updates from AmberTools 2024 RC #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at commit 30223a9e). Backport updates to QUICK-specific build files (quick-cmake). Omit updates to cmake/MPIConfig.cmake due to issues.
merzlab
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR pulls in the build system updates from the AmberTools 2024 RC (HEAD of master at commit 30223a9e) for the files under the
cmakedirectory, with care to port over QUICK-specific modifications. Also, updates have been ported over to relevant QUICK-specific build files inquick-cmake.Worth noting, changes in
cmake/MPIConfig.cmakewere omitted from this update due to build issues results from updates (likely due to QUICK CMake namespace issues).This also brings GPU support up to date with Amber (specifically for CUDA v12.4.x) support.