-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable C linting rules #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @ddundo. This linter option seems a bit over-the-top to me, to be honest. But I have a few suggestions that could improve things a bit.
Thanks @jwallwork23 - very good points! And before I address them, would you prefer if I added C901 to the ignore list if you think it's over-the-top? Then I could revert back to how it was if you'd like |
No it's okay, let's stick with it. It's better to go with linter recommendations rather than ignoring them. |
Thanks @jwallwork23 - this tidies it up nicely :) ready for review again |
Closes #108.
After #120, the remaining linting errors are:
This PR addresses all of them apart from the final one, to which I added
noqa: C901
. The complexity mostly comes from theif isinstance
checks so I don't think it's that bad to begin with. And I guess I could replace those withassert
but I would rather not do that. @jwallwork23 do you see a nice way to simplify it please? :)