Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fixed incorporating adapter version # at buildtime #125

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[Bug] Fixed incorporating adapter version # at buildtime #125

merged 1 commit into from
Aug 31, 2021

Conversation

mgfeller
Copy link
Contributor

Signed-off-by: Michael Gfeller mgfeller@mgfeller.net

Description

Added build-arg GIT_COMMITSHA and VERSION to docker build for edge and stable.

This PR fixes #124

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

…nd stable

Signed-off-by: Michael Gfeller <mgfeller@mgfeller.net>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote added area/ci Continuous integration | Build and release kind/bug Something isn't working labels Aug 31, 2021
Copy link
Member

@sayantan1413 sayantan1413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mgfeller ✔️

@mgfeller mgfeller merged commit 904e726 into meshery:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorporate Adapter Version # at buildtime
3 participants