-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #524
Update README.md #524
Conversation
Signed-off-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
@sandramsc review it. |
CC: @Mohith234 @Chadha93 @Modern-artist Hi @rohan472000, maintainers are the ones who generally review, merge PR's here, not necessarily the person who creates the issue. Also PR's are made once an issue is assigned to you, the issue referenced here hasn't been assigned yet. If you haven't already, consider reading the newcomers guide here, particularly the section on "Finding an Issue to Work On". |
Thanks for the clarification. As this issue was really minute, had nothing to discuss over it much, so I raised the PR. Now I've seen the guidelines thoruoghly of this repo, so next time I'll get issue assigned first & then raise PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate your enthusiasm @rohan472000 , Please do not create any PRs unless the issue is assigned to you. Read the contributing guidelines beforehand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you, @rohan472000 👍
Ready for your next issue, @rohan472000? |
Thank you for contributing to the Layer5 community! 🎉 \ \ |
Yeah sure :) |
Description
Made
Fill-in
bolder in readme of this repo.This PR fixes #523
Signed-off : Rohan Anand anand00rohan@gmail.com
Signed commits