Fixes #150 (Added meshery logo to the readme) #151
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
leecalcote
requested review from
Abhijay007,
aminoxix,
kamalbuilds and
YashKamboj
| @@ -1,3 +1,9 @@ | |||
| <p style="text-align:center;" align="center"><a href="https://layer5.io/meshery"><picture align="center"> | |||
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-dark-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | |||
There was a problem hiding this comment.
please do not use meshery/meshery 's logo, store it locally( if meshsync doesn't have it ) and then use relative referencing to get it.
| @@ -1,3 +1,9 @@ | |||
| <p style="text-align:center;" align="center"><a href="https://layer5.io/meshery"><picture align="center"> | |||
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-dark-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | |||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-light-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | |||
There was a problem hiding this comment.
On it @legendarykamal
|
@legendarykamal As per your suggestion, I have stored the logos locally and then used relative referencing to render them. |
|
@legendarykamal I'm closing this PR because of some error on my side and will be opening a new PR for the issue. |
Signed-off-by: Utkarsh Mishra nasautkarsh@gmail.com
Description
Added meshery logo to the readme
This PR fixes #150
Notes for Reviewers
Signed commits