Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon soup orientation not checked for volume meshing #103

Closed
bigfooted opened this issue Jul 29, 2020 · 3 comments
Closed

polygon soup orientation not checked for volume meshing #103

bigfooted opened this issue Jul 29, 2020 · 3 comments

Comments

@bigfooted
Copy link

When a surface mesh is remeshed using remesh-surface, the result is saved without proper orientation. cgal also does this. When loading this surface into a polyhedron instance for volume meshing, the loading fails (In my case always).

A solution for volume meshing is to read the points and polygons from file separately and then call CGAL::Polygon_mesh_processing::orient_polygon_soup() and CGAL::Polygon_mesh_processing::polygon_soup_to polygon_mesh () when a bad orientation is found, or do it always.

@nschloe
Copy link
Collaborator

nschloe commented Jul 29, 2020

Sure. Can you prepare a PR? Best make it an option, default False.

@bigfooted
Copy link
Author

No problem, I will add an activation switch.

@nschloe
Copy link
Collaborator

nschloe commented Aug 3, 2020

Fixed by #104.

@nschloe nschloe closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants