Feature reorient faces #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build fails, but I got the same thing when I tried to auto-install pygalmesh on my computer. I think it has to do something with the pip version. I had to manually install pygalmesh using python3 install |
nschloe
reviewed
Aug 3, 2020
pygalmesh/main.py
Outdated
| @@ -194,6 +194,7 @@ def generate_volume_mesh_from_surface_mesh( | |||
| cell_radius_edge_ratio=0.0, | |||
| cell_size=0.0, | |||
| verbose=True, | |||
| reorient=True, | |||
There was a problem hiding this comment.
As discussed, default False. Also in the C++ below.
nschloe
reviewed
Aug 3, 2020
src/generate_from_off.cpp
Outdated
| input.close(); | ||
|
|
||
| // NB: cgal has a check here to see if the input geometry is triangulated | ||
| // do we want it here? |
There was a problem hiding this comment.
Not sure. I'm not aware of any problems without the test.
No, it passes. The failure is from gh-actions which doesn't have a recent-enough cgal. Ignore that. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix face orientation of input mesh. Default is false. use --reorient or -t to activate
how to test: remesh a surface and then create a volume mesh from this surface:
$ pygalmesh-remesh-surface lion-head.off lionhead_remesh.off -e 0.025 -a 25 -s 0.1 -d 0.001
$ pygalmesh-volume-from-surface lionhead_remesh.off lionhead_remesh_vol.vtu
RuntimeError: Invalid input file "/tmp/tmpnq6ln74_.off"
If this is due to wrong face orientation, retry with the option --reorient "
$ pygalmesh-volume-from-surface lionhead_remesh.off lionhead_remesh_vol.vtu --reorient
$