Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move duplicate font definition code to common header file (tech dept) #3301

Closed
thoherr opened this issue Feb 27, 2024 · 1 comment
Closed

Comments

@thoherr
Copy link
Contributor

thoherr commented Feb 27, 2024

While implementing feature request #3284 i recognised that the definition of screen fonts is duplicated in several files, namely
src/graphics/Screen.cpp, src/modules/Telemetry/PowerTelemetry.cpp, src/modules/Telemetry/EnvironmentTelemetry.cpp, src/modules/CannedMessageModule.cpp.
To avoid breaking something, i even introduced another copy in src/modules/esp32/PaxcounterModule.cpp to implement the feature.

I propose to cleanup the duplicate code by moving it to a separate header file and indlude this in the files named above.

@thebentern
Copy link
Contributor

Closed with #3302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants