gnome.marshal() accept files in addition to strings for the sources #9827
Comments
|
The argument is semantically files, and as such we generally expect to allow files objects in addition to strings naming a file. The added type checking violated that constraint in many places -- I already fixed this for gtkdoc() and gdbus_codegen() in git master, but I didn't do a full cleanup, so more are probably lurking... This is a regression and needs to be fixed for 0.61.1. Update: apparently we used to only accept a string or an array of strings, with homebrew typechecking that only validated a list but not what was in it. However, it is not unreasonable to use files() here, and we immediately pass it in to a custom_target as inputs, which obviously works flawlessly, so the error message if you used |
eli-schwartz
added a commit
to eli-schwartz/meson
that referenced
this issue
Jan 14, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes mesonbuild#9827
|
Can you try the linked PR? |
eli-schwartz
added a commit
to eli-schwartz/meson
that referenced
this issue
Jan 14, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes mesonbuild#9827
|
Trying the PR gives no Here's the entire log from Here's the entire |
nirbheek
pushed a commit
to eli-schwartz/meson
that referenced
this issue
Jan 15, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes mesonbuild#9827
Test updated by Nirbheek Chauhan <nirbheek@centricular.com>
|
Still failing, with new errors: Though I don't know if that's meson or gnome-terminal. |
nirbheek
pushed a commit
to eli-schwartz/meson
that referenced
this issue
Jan 15, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes mesonbuild#9827
Test updated by Nirbheek Chauhan <nirbheek@centricular.com>
nirbheek
pushed a commit
to eli-schwartz/meson
that referenced
this issue
Jan 15, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes mesonbuild#9827
Test updated by Nirbheek Chauhan <nirbheek@centricular.com>
nirbheek
pushed a commit
that referenced
this issue
Jan 15, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes #9827
Test updated by Nirbheek Chauhan <nirbheek@centricular.com>
|
/cc @paper42 for linked PR |
nirbheek
pushed a commit
that referenced
this issue
Jan 16, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes #9827
Test updated by Nirbheek Chauhan <nirbheek@centricular.com>
Not related to meson. The PATCH 16/16 you use relies upon a revert within the branch Sorry for Off-Topic. |
Dudemanguy
pushed a commit
to Dudemanguy/meson
that referenced
this issue
Jan 21, 2022
It used to support:
- a single string
- an array of anything
And as long as CustomTarget supported it too, everything worked fine.
So, a `files('foo')` worked but a `files('foo')[0]` did not, which is
silly... and it's not exactly terrible to use files() here, the input is
literally a list of source files.
Fixes building gnome-terminal
Fixes mesonbuild#9827
Test updated by Nirbheek Chauhan <nirbheek@centricular.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
Since meson > 0.61 the method gnome.marshal() doesn't accept anymore a list of files for the parameter
sources. According to the documentation this is correct:I assume a more strict and therefore better type checking. The maintainers of gnome-terminal prefer to keep passing files. Is it possible to extend the API?
The text was updated successfully, but these errors were encountered: