Install meson.exe as the entrypoint on Windows #4004

nirbheek · 2018-08-10T10:36:19Z

Thanks to Rafael Rivera for the suggestion

MathieuDuponchelle

Looks good to me, and actually allows me to have usable meson after install on Windows, up until now I was always explicitly typing python3 C:/path/to/meson.py, that was a bit cumbersome :)

MathieuDuponchelle · 2018-08-10T18:34:37Z

mesonbuild/mesonmain.py

    if 'MESON_COMMAND_TESTS' in os.environ:
-        mlog.log('meson_command is {!r}'.format(mesonlib.meson_command))
+        print('meson_command is {!r}'.format(mesonlib.meson_command))


hrm, why would you switch to a print? If I understand correctly, mlog.log will jump through some extra hoops to avoid locale errors etc

Hmm, good point. I thought it would be simpler because it's only used in tests, but then the tests might fail on certain locales.

nirbheek · 2018-08-10T18:59:23Z

~~Looks like msys2-mingw python doesn't ship with setuptools?~~ Needs to be installed with pacman

C:\msys64\mingw32\lib\python3.6\distutils\dist.py:261: UserWarning: Unknown distribution option: 'python_requires' warnings.warn(msg)
C:\msys64\mingw32\lib\python3.6\distutils\dist.py:261: UserWarning: Unknown distribution option: 'entry_points' warnings.warn(msg)

How strange.

Thanks to Rafael Rivera for the suggestion Fixes #1877

This gives us a consistent experience and a simpler setup across all operating systems. Setuptools is available everywhere these days.

nirbheek · 2018-08-11T11:15:27Z

So I nuked distutils and now we require setuptools. Do we need to support distutils for some platforms or is this ok? I know for a fact that macOS and Windows Python installers ship with setuptools, and on MSYS2 you can install it with pacman. That leaves Linux, and Fedora ships with setuptools by default.

lazka · 2018-08-11T12:40:17Z

There are so many things depending on setuptools for install that I don't think this is going to be a problem.

ignatenkobrain · 2018-08-11T12:43:47Z

Do not ever touch dead distutils :) nothing in this world works without setuptools

nirbheek · 2018-08-11T16:19:13Z

I have no idea why we try to support both distutils and setuptools. The commit message which added setuptools doesn't say:

commit 2e42427d4ac17e3fce819c7d3095c354c4c3c555
Author: Jussi Pakkanen <jpakkane@gmail.com>
Date:   Sat Jan 16 20:09:47 2016 +0200

    Support both setuptools and distutils.

and the initial setup.py used distutils.

jpakkane · 2018-08-11T17:24:42Z

Setuptools is not in the Python standard library, only distutils is so our requirement for not depending on anything outside of the standard library comes into play here.

Also, setuptools produced broken files with sdist back when I last tried it. There were a bunch of files missing at random without any reason or pattern.

nirbheek · 2018-08-11T17:31:47Z

Setuptools is not in the Python standard library, only distutils is so our requirement for not depending on anything outside of the standard library comes into play here.

That requirement is for running meson, though. For instance, we depend on hotdoc for our documentation.

Also, setuptools produced broken files with sdist back when I last tried it. There were a bunch of files missing at random without any reason or pattern.

We have tests for this now, although we don't check the complete files list in it yet.

lazka · 2018-08-11T17:35:10Z

That requirement is for running meson, though. For instance, we depend on hotdoc for our documentation.

Afair the generated entry point scripts depend on pkg_resources

ignatenkobrain · 2018-08-11T19:27:15Z

run_meson_command_tests.py

@@ -19,6 +19,7 @@
 import unittest
 import subprocess
 import zipapp
+from glob import glob


[Flake8]

[F401] 'glob.glob' imported but unused

ignatenkobrain · 2018-08-11T19:48:13Z

run_meson_command_tests.py

        self.assertTrue(bindir.is_dir())
+        self.assertTrue(pylibdir.is_dir())
+        from setup import  packages


[Flake8]

[E271] multiple spaces after keyword

Ensure that the installed files list matches what we expect, to avoid surprises at release time.

nirbheek · 2018-08-11T19:54:10Z

I've added tests that verify the files list. Looks fine. Can you run it on Debian to test?

nirbheek · 2018-08-11T19:54:45Z

Afair the generated entry point scripts depend on pkg_resources

That module is shipped with setuptools, right?

jpakkane · 2018-08-11T20:33:50Z

I tested this branch with Debian Sid's setuptools and the result was working just fine. Whatever the issue was it seems to be gone now.

nirbheek · 2018-08-11T21:25:19Z

I think we should merge this so we have good Windows support out-of-the-box. distutils was a horrible failure, and setuptools is expected to be used by anyone trying to build + install python packages. It also does not change the "run from git" workflow at all.

anthrotype · 2018-08-31T14:43:40Z

When will this patch be released? I don't see it in the latest 0.47.2 as currently available from PyPI.
thanks

nirbheek · 2018-08-31T14:51:53Z

This will be in the 0.48 release. You can find a full list of changes that went into 0.47.2 at https://github.com/mesonbuild/meson/milestone/29?closed=1.

nirbheek · 2018-08-31T14:54:25Z

However, you can use it with git master by doing pip3 install git+https://github.com/mesonbuild/meson

anthrotype · 2018-08-31T15:06:57Z

thanks!

jbicha · 2018-09-24T03:34:17Z

@jpakkane I guess this is where https://bugs.debian.org/909440 came from?

nirbheek · 2018-09-24T07:12:39Z

Repeating what I said on IRC, pkg-resources is a part of setuptools, and we require setuptools now. No idea why Debian splits that out to its own package and adds it as a dependency to setuptools, but simply depending on setuptools in Debian should be enough.

mbiebl · 2018-09-24T21:45:50Z

@nirbheek The comment in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=909440#10 says that meson is not supposed to depend on anything outside of python3. If python(3)-setuptools is required, then such a dependency would need to be added to the package.

nirbheek · 2018-09-24T21:49:09Z

If python(3)-setuptools is required, then such a dependency would need to be added to the package.

See above, we discussed this requirement before committing this. I commented here to state that @jpakkane has forgotten and commented mistakenly on the Debian bug.

mbiebl · 2018-09-24T22:04:43Z

Ah ok. Regarding your remark about "no idea why Debian splits that out to its own package", I only found:

python-setuptools (0.6c8-1) unstable; urgency=low

  * New upstream version. Closes: #467012.
  * Split out a python-pkg-resources package (to be used as a runtime
    dependency instead of python-setuptools).

 -- Matthias Klose <doko@debian.org>  Fri, 29 Feb 2008 01:20:15 +0100

Looking at python3-pkg-resources, it weighs 535K,
python3-setuptools(+dependencies) is 3975K

nirbheek · 2018-09-24T22:10:14Z

Ah, so setuptools is supposed to be a build-time dependency and pkg-resources a runtime dependency. We don't need the runtime dependency in Meson though.

mbiebl · 2018-09-24T22:16:17Z

I think it's the other way around: meson needs only pkg-resources as a runtime dependency, or am I completely confused?

nirbheek · 2018-09-24T22:30:10Z

Meson doesn't really need the pkg-resources runtime dependency on Linux since we just need to call mesonmain.main(). It is, however, needed on Windows for exe files. I misread the Debian bug and thought the stacktrace was coming from setup.py.

We could quite easily remove the dependency by using entry_points= only on Windows. It would be nice to do that without reinstating the ugly install_scripts hack though.

mbiebl · 2018-09-24T22:32:16Z

Well, there is

from pkg_resources import load_entry_point

in /usr/bin/meson, so I guess meson does need pkg-resources at runtime

nirbheek · 2018-09-24T22:34:39Z

Yes, and that dependency comes from our usage of setuptools entry_points=. Which can be conditional. Since we don't really need it on any platform except Windows.

jbicha · 2018-09-24T22:52:38Z

@nirbheek Yes, that sounds like my understanding of what @jpakkane wants here.

albfan · 2018-11-15T11:24:33Z

@nirbheek this breaks for me in msys2 https://github.com/Alexpux/MINGW-packages/issues/4659 @lazka any ideas?

nirbheek force-pushed the nirbheek/console-entrypoint branch 2 times, most recently from 042e78d to ddf5855 Compare August 10, 2018 10:54

MathieuDuponchelle reviewed Aug 10, 2018

View reviewed changes

Install meson.exe as the entrypoint on Windows

2ee2802

Thanks to Rafael Rivera for the suggestion Fixes #1877

nirbheek force-pushed the nirbheek/console-entrypoint branch from c7bd268 to 2ee2802 Compare August 10, 2018 21:50

setup: Require setuptools and entry_points:

86298f2

This gives us a consistent experience and a simpler setup across all operating systems. Setuptools is available everywhere these days.

nirbheek assigned jpakkane Aug 11, 2018

ignatenkobrain reviewed Aug 11, 2018

View reviewed changes

nirbheek force-pushed the nirbheek/console-entrypoint branch 2 times, most recently from b225f25 to f6836f2 Compare August 11, 2018 19:47

ignatenkobrain reviewed Aug 11, 2018

View reviewed changes

setup: Add tests for the installed files list

c0413f5

Ensure that the installed files list matches what we expect, to avoid surprises at release time.

nirbheek force-pushed the nirbheek/console-entrypoint branch from f6836f2 to c0413f5 Compare August 11, 2018 19:49

jpakkane merged commit f335c8b into master Aug 11, 2018

jpakkane deleted the nirbheek/console-entrypoint branch August 11, 2018 21:44

nirbheek mentioned this pull request Sep 26, 2018

meson 0.48.0 quietly introduces dependency on setuptools package #4267

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install meson.exe as the entrypoint on Windows #4004

Install meson.exe as the entrypoint on Windows #4004

nirbheek commented Aug 10, 2018

MathieuDuponchelle left a comment

MathieuDuponchelle Aug 10, 2018

nirbheek Aug 10, 2018

nirbheek commented Aug 10, 2018 •

edited

Loading

nirbheek commented Aug 11, 2018

lazka commented Aug 11, 2018

ignatenkobrain commented Aug 11, 2018

nirbheek commented Aug 11, 2018

jpakkane commented Aug 11, 2018

nirbheek commented Aug 11, 2018

lazka commented Aug 11, 2018

ignatenkobrain Aug 11, 2018

ignatenkobrain Aug 11, 2018

nirbheek commented Aug 11, 2018

nirbheek commented Aug 11, 2018

jpakkane commented Aug 11, 2018

nirbheek commented Aug 11, 2018

anthrotype commented Aug 31, 2018

nirbheek commented Aug 31, 2018 •

edited

Loading

nirbheek commented Aug 31, 2018

anthrotype commented Aug 31, 2018

jbicha commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

jbicha commented Sep 24, 2018

albfan commented Nov 15, 2018

Install meson.exe as the entrypoint on Windows #4004

Install meson.exe as the entrypoint on Windows #4004

Conversation

nirbheek commented Aug 10, 2018

MathieuDuponchelle left a comment

Choose a reason for hiding this comment

MathieuDuponchelle Aug 10, 2018

Choose a reason for hiding this comment

nirbheek Aug 10, 2018

Choose a reason for hiding this comment

nirbheek commented Aug 10, 2018 • edited Loading

nirbheek commented Aug 11, 2018

lazka commented Aug 11, 2018

ignatenkobrain commented Aug 11, 2018

nirbheek commented Aug 11, 2018

jpakkane commented Aug 11, 2018

nirbheek commented Aug 11, 2018

lazka commented Aug 11, 2018

ignatenkobrain Aug 11, 2018

Choose a reason for hiding this comment

ignatenkobrain Aug 11, 2018

Choose a reason for hiding this comment

nirbheek commented Aug 11, 2018

nirbheek commented Aug 11, 2018

jpakkane commented Aug 11, 2018

nirbheek commented Aug 11, 2018

anthrotype commented Aug 31, 2018

nirbheek commented Aug 31, 2018 • edited Loading

nirbheek commented Aug 31, 2018

anthrotype commented Aug 31, 2018

jbicha commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

mbiebl commented Sep 24, 2018

nirbheek commented Sep 24, 2018

jbicha commented Sep 24, 2018

albfan commented Nov 15, 2018

nirbheek commented Aug 10, 2018 •

edited

Loading

nirbheek commented Aug 31, 2018 •

edited

Loading