Fix executable as script on Windows #8259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging f63177c into 0f5a136 - view on LGTM.com new alerts:
|
xclaesse
force-pushed
the
exe-serialisation
branch
from
f63177c
to
469bec1
Compare
|
This pull request introduces 1 alert when merging 469bec1 into 0f5a136 - view on LGTM.com new alerts:
|
xclaesse
force-pushed
the
exe-serialisation
branch
2 times, most recently
from
d2773f5
to
f2cf8b6
Compare
|
This pull request introduces 1 alert when merging f2cf8b6 into 9d602e6 - view on LGTM.com new alerts:
|
xclaesse
force-pushed
the
exe-serialisation
branch
10 times, most recently
from
1cd1172
to
b240f55
Compare
On Windows this would fail because of missing DLL: ``` mylib = library(...) exe = executable(..., link_with: mylib) meson.add_install_script(exe) ``` The reason is on Windows we cannot rely on rpath to find libraries from build directory, they are searched in $PATH. We already have all that mechanism in place for custom_target() using ExecutableSerialisation class, so reuse it for install/dist/postconf scripts too. This has bonus side effect to also use exe_wrapper for those scripts. Fixes: mesonbuild#8187
xclaesse
force-pushed
the
exe-serialisation
branch
from
b240f55
to
11f23e3
Compare
|
Failing CI seems unrelated, I think it's ready for review. |
This was referenced Jan 29, 2021
bruchar1
added a commit
to bruchar1/meson
that referenced
this pull request
Feb 9, 2023
\mesonbuild#8259 induced a regression, causing Meson 0.57.0 and upward to stop printing outputs of source scripts. This makes _find_source_scripts() mark executables as verbose in meson_exe.
bruchar1
added a commit
to bruchar1/meson
that referenced
this pull request
Feb 9, 2023
mesonbuild#8259 induced a regression, causing Meson 0.57.0 and upward to stop printing outputs of scripts added using `meson.add_*_script()`. This makes _find_source_scripts() mark executables as verbose in meson_exe.
eli-schwartz
pushed a commit
that referenced
this pull request
Feb 13, 2023
#8259 induced a regression, causing Meson 0.57.0 and upward to stop printing outputs of scripts added using `meson.add_*_script()`. This makes _find_source_scripts() mark executables as verbose in meson_exe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows this would fail because of missing DLL:
The reason is on Windows we cannot rely on rpath to find libraries from
build directory, they are searched in $PATH. We already have all that
mechanism in place for custom_target() using ExecutableSerialisation
class, so reuse it for install/dist/postconf scripts too.
This has bonus side effect to also use exe_wrapper for those scripts.
Fixes: #8187