-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python module: produce the correct install path on every OS #9156
python module: produce the correct install path on every OS #9156
Conversation
The sysconfig paths are, by default, correct for every OS -- they are supposed to follow the scheme that python knows about per default. For some reason, this overrode the scheme to posix_prefix, which is the default for posix OSes like linux and macOS, but wrong on Windows. Simply deleting this entirely makes everything that used to work, still work, and a couple new things start working.
Codecov Report
@@ Coverage Diff @@
## master #9156 +/- ##
==========================================
- Coverage 66.69% 63.52% -3.18%
==========================================
Files 378 189 -189
Lines 84510 42192 -42318
Branches 17491 8733 -8758
==========================================
- Hits 56368 26802 -29566
+ Misses 23349 13038 -10311
+ Partials 4793 2352 -2441 Continue to review full report at Codecov.
|
I'm wondering if we should go one step further on Windows. By default |
otoh, this is always going to be at best a guess. Maybe what we really need is adding an option, we discussed recently we should allow modules to add their own options. Currently every project that install python modules pretty much have to add their own option which makes it inconsistent. |
@eli-schwartz I remember writing this specific line, but I really don't remember the reason, should have added an inline comment probably :( |
Forgot that this isn't merged yet... Note this has been discussed previously in #3995 which this would fix. |
The sysconfig paths are, by default, correct for every OS -- they are supposed to follow the scheme that python knows about per default.
For some reason, this overrode the scheme to posix_prefix, which is the default for posix OSes like linux and macOS, but wrong on Windows. Simply deleting this entirely makes everything that used to work, still work, and a couple new things start working.
@MathieuDuponchelle I'm seeking insight into why this originally got implemented the way it did. Do you happen to remember?
Fixes #3995