Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing MESOS_TASK_ID environment variable #804

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Add missing MESOS_TASK_ID environment variable #804

merged 1 commit into from
Feb 16, 2017

Conversation

lionelnicolas
Copy link
Contributor

As MESOS_TASK_ID is an environment variable, it should be uppercase.

brndnmtthws
brndnmtthws requested changes Feb 16, 2017
View reviewed changes
Copy link
Member

@brndnmtthws brndnmtthws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may break code which now depends on this behaviour. Can we instead add an additional environment variable? We can remove the old one at a later time.

@lionelnicolas
Add missing MESOS_TASK_ID environment variable
7a18b11 
As `MESOS_TASK_ID` is an environment variable, it should be uppercase.
For backward compatibility, the lowercase `mesos_task_id` is kept for
the moment.
@lionelnicolas lionelnicolas changed the title Fix MESOS_TASK_ID environment variable Add missing MESOS_TASK_ID environment variable Feb 16, 2017
@lionelnicolas
Copy link
Contributor Author

Ok I've updated the PR to keep the lowercase variable as well.

@brndnmtthws brndnmtthws merged commit 378cbfc into mesos:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brndnmtthws brndnmtthws brndnmtthws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionelnicolas @brndnmtthws