Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding: refactor Decoder and Encoder as single-function interfaces w/ functional adapters #299

Merged
merged 1 commit into from
May 2, 2017
Merged

encoding: refactor Decoder and Encoder as single-function interfaces w/ functional adapters #299

merged 1 commit into from
May 2, 2017

Conversation

jdef
Copy link
Contributor

@jdef jdef commented Apr 28, 2017 •
edited
Loading

breaking API changes:

  • functional variants are now encoding.DecoderFunc and encoding.EncoderFunc
  • Response now composes encoding.Decoder instead of exposing a Decoder() func

@coveralls
Copy link

coveralls commented Apr 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 36.475% when pulling 1999317 on jdef_refactor_encoding_interfaces into d0dc16a on master.

@jdef jdef added PTAL and removed WIP labels Apr 28, 2017
@jdef jdef merged commit fe43f9c into master May 2, 2017
@jdef jdef deleted the jdef_refactor_encoding_interfaces branch May 2, 2017 03:07
@jdef jdef removed the PTAL label May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api/v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdef @coveralls