[[--WIP--]] bump to mesos 1.5 protos, reservation refinements, et al. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jdef
commented
Nov 8, 2017
api/v1/lib/resources.go
Outdated
| if aa, bb := a.GetMetadata(), b.GetMetadata(); (aa == nil) != (bb == nil) { | ||
| return false | ||
| } else if !reflect.DeepEqual(aa.GetLabels(), bb.GetLabels()) { | ||
| // TODO(jdef) can we do better than DeepEqual here? |
There was a problem hiding this comment.
TODO: consider something better here
api/v1/lib/resources.go
Outdated
|
|
||
| // IsDisk returns true if this is a disk resource of the specified type. | ||
| func (left *Resource) IsDisk(t Resource_DiskInfo_Source_Type) bool { | ||
| if d := left.Disk; d != nil { |
There was a problem hiding this comment.
should this bomb if left is nil?
api/v1/lib/resources.go
Outdated
|
|
||
| // HasResourceProvider returns true if the given Resource object is provided by a resource provider. | ||
| func (left *Resource) HasResourceProvider() bool { | ||
| return left.ProviderID != nil |
There was a problem hiding this comment.
should this bomb if left is nil?
| ) | ||
|
|
||
| var ( | ||
| opNoop = func(_ *mesos.Offer_Operation, _ mesos.Resources) (_ mesos.Resources, _ error) { return } | ||
| opError = func(t mesos.Offer_Operation_Type) offerResourceOp { |
There was a problem hiding this comment.
nit: rename opUnsupported
added 2 commits
November 8, 2017 17:53
…fleshed out validation for resources w/ disk, reservations, and shares
jdef
force-pushed
the
jdef_bump_mesos_protos_a94e3cd0fc612
branch
from
17e1924
to
8ef9d96
Compare
… refinements, resv push/pop
jdef
changed the title
1 similar comment
|
https://issues.apache.org/jira/browse/MESOS-8237 (mesos allocation info/non-multi-role capable frameworks/libraries compat) |
|
@jdef https://issues.apache.org/jira/browse/MESOS-8237 was merged into master 5 days ago, and that change will soon be included in dcos/dcos master with dcos/dcos#2165 |
|
thanks for the update!
…On Wed, Dec 6, 2017 at 11:27 PM, Adam ***@***.***> wrote:
@jdef <https://github.com/jdef> https://issues.apache.org/
jira/browse/MESOS-8237 was merged into master 5 days ago, and that change
will soon be included in dcos/dcos master with dcos/dcos#2165
<dcos/dcos#2165>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#335 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLF71WRlZTvhSatqxH0zPiJCmRN5Jks5s92k5gaJpZM4QUBwU>
.
|
|
superseded by #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/mesos@1.4.0...a94e3cd
api/v1/lib/allocator/allocator.protoapi/v1/lib/executor/executor.protoapi/v1/lib/maintenance/maintenance.protoapi/v1/lib/quota/quota.protonon-proto changes:
deferred:
ReconcileOfferOperationsis a synchronous call but theResponsescheduler protos haven't landed yet: https://docs.google.com/a/mesosphere.io/document/d/1GGh14SbPTItjiweSZfann4GZ6PCteNrn-1y4pxOjgcI/edit?disco=AAAABAZjNtg